Pycodestyle: 2.1 release

Created on 15 Sep 2016  路  9Comments  路  Source: PyCQA/pycodestyle

I was wondering if it would be possible to cut the 2.1 release?

The https://github.com/PyCQA/pycodestyle/milestone/13 milestone appears to be complete.

If there's anything else that should be done before the release, I'm happy to help.

Most helpful comment

Done. Sorry for the ridiculous delay. That's on me.

The new release has been cut and pushed to PyPI. Let me know if anyone notices any issues! Thanks for the help @daspecster ! And big thanks to @sigmavirus24 as always!

All 9 comments

Thanks for asking @daspecster ! Actually one thing that would be super helpful, and which I dropped the ball on is updating the changelog with everything that's happened since 2.0. Would that be something you would be willing to help with?

@IanLee1521, sure no problem!

@sigmavirus24 in particular, but anyone that wants to weigh in -- I was just looking over things for the 2.1 release, and I wanted to run something by you. One of the issues that was fixed was #530 which I believe may have had an unexpected side effect.

By changing the name of the program (https://github.com/PyCQA/pycodestyle/blob/master/pycodestyle.py#L2050) from pep8 to pycodestyle this changes the config section name from pep8 to pycodestyle which would break (ignore) anyone's config that was using the old name. In the long run, that is what we want. But as a backwards incompatible change, I think it's an issue to address.

I see two paths forward. First is to add logic that would handle either name for the section (around https://github.com/PyCQA/pycodestyle/blob/master/pycodestyle.py#L2148), but with a warning that the pep8 section name is deprecated in preference to pycodestyle. Or second, keep the change as is, but note it as backwards incompatible and release the next version as 3.0 instead of 2.1. This would also allow for merging in https://github.com/PyCQA/pycodestyle/pull/433.

Any thoughts (from anyone) on these two solutions?

My vote would be for option 2 with a message that the '[pep8]' section was deprecated.

Supporting the ['pycodestyle] section is actually one of the changes that I'm looking for.
https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2020

I would opt for option 1. But option 2 is suitable for me too.

@sigmavirus24 @IanLee1521, WDYT about cutting a release? Are there any other issues I could help with to get to 2.1 or 3.0?

@IanLee1521 I'm happy to help by cutting the release.

Done. Sorry for the ridiculous delay. That's on me.

The new release has been cut and pushed to PyPI. Let me know if anyone notices any issues! Thanks for the help @daspecster ! And big thanks to @sigmavirus24 as always!

Thanks @IanLee1521 and @sigmavirus24!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

coxley picture coxley  路  5Comments

jtpavlock picture jtpavlock  路  3Comments

Nyrio picture Nyrio  路  4Comments

willhardy picture willhardy  路  5Comments

garawalid picture garawalid  路  4Comments