Does anyone know how to get the IR-Lock to work with GQC?
I've done all the set up for it using the PixyMon, but after that I can't find anything with integrating it on the px4 stack with the pixhawk. Was wondering what type of parameters I would have to set or does the IR-Lock start to work automatically.
@kevinlyu1 IRLock has a driver on firmware but the data of it is no being used still.
So basically the IR-Lock won't work on the px4 stack?
The driver is here: https://github.com/PX4/Firmware/blob/4453e4201b7a245cff52beeb38a293161aea4c48/src/drivers/irlock/irlock.cpp. From here to implementing usability there are some things that can be done (data logging, precision landing, data wrap to LANDING_TARGET msg). So the driver allows to get the data on the stack, but nothing is done besides the driver right now. You are welcomed to purpose a PR that implements that usage.
What do you mean by a PR?
Pull Request
Okay thanks!
@TSC21 Hey I am working on px4 and pixy camera using the irlock driver included in Firmware/src/drivers/irlock.
I was interested in contributing the usability features (data logging, data wrap to LANDING_TARGET msg) since I'll be needing them soon.
Can you point me to some existing drivers which I can use for reference to implement these features?
PS - For people working on the irlock. The driver is not compiled by default. You can add drivers/irlock to Firmware/cmake/configs/<target_board>.cmake along with other drivers. This would give you irlock command in the nsh terminal of px4.
@ShikherVerma check how other distance sensor drivers are implemented for example. But in this case you would want a landing_target uORB topic to publish to and use the data published to it to implement a precision landing procedure in mc_pos_control for example when LANDING mode is activated (or when a landing setpoint/waypoint is set and the vehicle is on MISSION mode).
@ShikherVerma I am also working on getting the IRLock working in PX4. We have modified the driver to publish its data on a uorb message. Currently I am working on implementing precision landing with it.
What are your goals with the IRLock?
I wanted to compare landing with IRLock w.r.t. landing with other techniques. So I would have to do the same things as you. Publish its data on a uorb message and implement precision landing with it. Can you link to your commits/branch where you have worked on irlock ?
https://github.com/ndepal/Firmware/tree/feature-precland
Consider this very much work in progress. While the estimator is tested a bit on hardware, I have not flown with it on hardware, only SITL.
I intend to open a PR that includes the driver changes, the beacon estimator, and a precision lander next week.
Would very much appreciate testers.
I'd like to try this out with Intel Aero RTF drone.
Is there an overview doc that describes a quick start? For example:
How does the user activate precision landing?
Any specific parameters that need to be set?
...etc.
Looking forward to it. Thanks.
Documentation is here: https://github.com/PX4/Firmware/issues/7580#issuecomment-336496565
The feature is now available in master.
Thanks for the reply, but I think there's something wrong with that link. It refers to this web page.
Sorry, here it is: https://docs.px4.io/en/advanced_features/precland.html
Great! Thank you.
Most helpful comment
https://github.com/ndepal/Firmware/tree/feature-precland
Consider this very much work in progress. While the estimator is tested a bit on hardware, I have not flown with it on hardware, only SITL.
I intend to open a PR that includes the driver changes, the beacon estimator, and a precision lander next week.
Would very much appreciate testers.