Pwa-studio: [bug]: Unwanted content displayed in search suggestion box when there are no results for search
Steps -
- Go to Venia store front and click on search icon.
- Enter search string which should not return any results. example - afgdsgedf
Expected - Search suggestion box should just display "No results were found."
Actual - Its displaying some extra content with above message.
dpatil-magento
All 7 comments
Note for QA - When this bug gets fixed, Need to un-comment lines in AssertNoResultsInSuggestionBox action group of MFTF tests. QA resource will take care of it.
dpatil-magento
on 15 May 2019
When i check https://magento-venia.now.sh I can't reproduce the issue, but when i setup venia locally i can reproduce it. I'd like to take ownership of this issue but want to be sure that it's still an actual problem ?
Jordaneisenburger
on 31 May 2019
@Jordaneisenburger https://magento-venia.now.sh has PWA 2.1.0 release. Please check on develop branch i.e. https://develop.pwa-venia.com
dpatil-magento
on 31 May 2019
@dpatil-magento I'd like to take ownership of this issue.
Jordaneisenburger
on 31 May 2019
Looks like a community member submitted a PR for this already (#1252)
tjwiebell
on 31 May 2019
Yes, I created my first PR on pwa-studio 2 weeks ago. Can you review and give me feedback?
khoa-le
on 1 Jun 2019
@khoa-le Taking a look at your #1252 now :thumbsup:
supernova-at
on 24 Jun 2019
Related issues
ericerway
路
6Comments
fooman
路
4Comments
supernova-at
路
4Comments
larsroettig
路
6Comments
Jordaneisenburger
路
5Comments
Most helpful comment
Looks like a community member submitted a PR for this already (#1252)