Pundit: Pundit v1.2.0?

Created on 10 Oct 2016  路  15Comments  路  Source: varvet/pundit

Hi!

First of all, thanks for the work on this gem!

I was struggling to make this code work (from the README), since authorize kept returning true:

def show
  @user = authorize User.find(params[:id])
end

Then I saw that the fixes that make this code work are not released in any version, they are only in master. Could you please release a new version? There are quite a few changes since the last version, too:

https://github.com/elabs/pundit/compare/b0bdfbc0db601ea4cc6cfcb243a657396c3e0f82...master

Thank you!

Most helpful comment

I will spend some time this week or next week going through the issues and I will try to release a new version.

All 15 comments

I had the same issue and then realised (after going through the issues) that this is not released yet.

How compatible/stable is master? I might use it in my gemfile instead for now (hobby-ing on something).

Yeah, especially https://github.com/elabs/pundit/commit/b9b2fdc162dd26b7e23029ed7b9414738f8cd614 is very important to our own project.

@abuisman, we use the master version inside our own project and have not faced any issues so far.

@jnicklas maybe add more maintainers?

Project seems abandoned, maybe fork and release "pundit2"?

@aried3r Thank you for the information, I went ahead with master.

@ce07c3 That seems a bit quick, the last commit was 4 months ago and if you look at the history: https://github.com/elabs/pundit/commits/master there have been some pretty consistent commits in the period before that. I have no idea what is going on right now, but maybe there is some other way to get in touch with the author?

Imho a project that has no commits in 4 months and is actively used as this one, means the maintainers have abandoned ship. We need more frequent updates.

@ce07c3 I agree that there should be some more activity, which for the maintainers would probably mean adding some maintainers, but creating a fork and advertising that as 'version 2' would just create a more diffuse set of 'pundit-like' or 'pundit-version' gems.

Have you tried getting in touch with elabs? They have contact information on their organisation page.

Hello, I'm here, and this project is not abandoned, just low activity. Frankly I don't spend a lot of time working on open source these days, and when I was at Elabs this was mainly my project, which is why they don't put much time into it either.

The main blocker for releasing a new version are the changes we want to make to the namespace API, see #351. My intention was to bump the version number to 2.0 and to also include this change, which is a breaking change, which is why it can't be released in a minor version.

As for how much maintenance this project needs: please recall that this project has like 100LOC. It is essentially "finished" for the most part. Yes there is little activity, but there really doesn't _need_ to be either, because honestly there isn't much to do.

I will spend some time this week or next week going through the issues and I will try to release a new version.

@jnicklas Thanks for the update. I quite agree with regards to it being done. Not sure what more could be done besides some documentation (from looking at the issues).

Looking forward to the 'new version'.

Not much to do vs. no release despite changes :) thanks for taking care of it!

I'm working through the currently open issues now. Closing this as it's not really an issue. Hopefully I can make a new release today.

I realize this issue was closed, but has there been any movement on the next version of Pundit? Even releasing a few of the minor features added to master would be a big win.

@jnicklas What are the blockers to a release? Do you need testers?

@jnicklas can you please add more maintainers?

Any progress?

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ucarion picture ucarion  路  4Comments

dowi picture dowi  路  4Comments

epinault picture epinault  路  6Comments

mattruzicka picture mattruzicka  路  5Comments

vmcilwain picture vmcilwain  路  5Comments