Protractor: selenium 4 upgrade: move test suite off of the control flow

[cnishina]

move test suite off of the control flow

test suite should pass here

complete by: 11/09

cnishina work:

• [x] basic/element_spec.js
• [x] basic/lib_spec.js
• [x] basic/locators_spec.js
• [x] basic/mockmodule_spec.js
• [x] altRoot/*_spec.js and inferRoot/*_spec.js
• [x] mocha/*_spec.js
• [x] onCleanUp/*_spec.js
• [x] onPrepare/*_spec.js
• [x] suites/*_spec.js
• [x] withLogin/*_spec.js
• [x] plugins/*_spec.js
• [x] interaction
• [x] restartBrowserBetweenTestConf
• [x] directConnect, getCapabilities
• [x] driverProviderUseExistingWebDriver <-- I think this needs to be removed
• [x] controlLock
• [x] noCF built tests
• [x] error tests
• [x] driverProviderLocal
• [x] driverProviderAttachSession
• [x] failure tests
• [x] turn on tests in suite not turned on (probably due to merging).
• [x] final review: ci test suite (travis) and basicConf.js should use all the spec files. Not just the subset we used for testing.

Misc:

• [x] address travis failures and grow the full suite.
  
  
  
  • [x] investigate spec/ng2/async_spec.js changing expected conditions from 1 to 2 and the window from 4 seconds to 7 seconds.
  
  
  • [x] also not sure about this test: #5027. This will have to be addressed.
  
  

@CrispusDH, this means in the basic, I will not touch these files if you want to take a shot at them. Please work on one file at a time as a pull request.

• [x] basic/expected_conditions_spec.js
• [x] basic/handling_spec.js
• [x] basic/navigation_spec.js
• [x] basic/polling_spec.js
• [x] basic/restart_spec.js
• [x] basic/synchronize_spec.js
• [x] angular2 (we'll have to look into this one). Note in Misc (above)
• [x] customFramework
• [x] noGlobals
• [x] hybrid
• [x] interactive_tests <-- Need to turn on <-- update: deleted

Also a quick review of the PR submitted #4998, it looks like you have a lot of trailing spaces on lines. If you are using visual studio code, there is a setting to remove trailing settings. (https://stackoverflow.com/questions/30884131/remove-trailing-spaces-automatically-or-with-a-shortcut)

[cnishina]

@CrispusDH I added a few more items to your list. We'll get them merged. It will require some rebasing. I just found the resolve conflicts button...if its a quick merge conflict, I'll take care of it.

[cnishina]

For the driverProviderUseExisting note above:

Added some discussion in a previous PR https://github.com/angular/protractor/pull/4756. This appears to be already accomplished in existing code. I plan to remove these changes and commit them into the selenium4 branch.

As part of this work, removed q.

[CrispusDH]

@cnishina , could I help with something else? Thanks again for opportunity to contribute :)

[cnishina]

@CrispusDH I want to move the spec.js files to TypeScript. It should be pretty easy (will create an example to try it out). Also, I'll create a separate issue to track it.

[cnishina]

There are 2 ~ 3 more issues that remain... so so close. Should be done by tomorrow.

For issue tracking notes, the fix for Travis / Sauce Labs was to update the browser version.

[cnishina]

With https://github.com/angular/protractor/pull/5069, this should be done.

[cnishina]

Done!