Protractor: selenium 4 upgrade process

[cnishina]

The [email protected] upgrade process will be against the selenium4 branch. These will be code reviewed; however the tests might not pass.

change as much as possible without upgrading selenium-webdriver:

• [x] move test suite off of the control flow (test suite should pass here) - 11/09 #5017
• [x] remove the control flow - 11/23
• [x] convert webdriver.promise.Promise to native Promise - 11/23
• [x] convert q promises to native promises - 11/23
• [x] clean up ignoreSynchronization as deprecated - 11/23
• [x] remove lib/debugger
• [x] remove jasminewd2 - 11/23
  
  
  
  • [x] fix locators_spec.js. Has a commented out test in reference to "custom expectations". See #5001
  
  

unforeseen steps (pushing out timeline by a week):

• [x] update internal runners
• [x] update internal test targets

also unforseen internal fixit week (pushing out timeline by another week):

copy over new selenium-webdriver typings to fix api calls:

• [x] fix protractor with new typing changes - 11/30 12/07 12/14
• [x] review changelog items from selenium4 - 11/30 12/07 12/14

upgrade selenium 4:

• [x] upgrade deps to selenium 4 (tests will probably fail) - 11/30 12/07 12/14
• [x] spend a magical amount of time hitting head against wall fixing things (if all goes well, maybe a week doing this) - 11/30 12/07 12/14

clean up:

• [ ] move test suite to typescript - 12/07 12/14 12/21
• [ ] light refactor with circle.yml file to .circleci folder - 12/07 12/14 12/21
• [ ] look into bstack tests on travis failing (currently commented out)

wishlist:

• [ ] remove extended webdriver js - 11/23 <-- this might not happen
• [x] maybe migrate over to webdriver-manager-replacement? or remove it from package.json - 12/21

[cnishina]

Falling behind schedule. Nooooooo! Note to Craig, work faster.

Side note, there are internal test targets that are being worked on.

[cnishina]

Closing this issue as done. The clean up efforts are being tracked in other issues.

[BorntraegerMarc]

Is selenium 4 currently supported? As a dependency I still see 3.6.0 being used: https://github.com/angular/protractor/blob/71771dee4e87526dffb725cacac3f9f9e1efc287/package.json#L26

[devoto13]

Nope, all goodies from v6 we reverted in v7, because there were no clear upgrade path from the control flow to async/await for the Angular ecosystem.