Protobuf: google.golang.org/grpc: move protoc-gen-go-grpc into grpc module

Created on 16 Jul 2019  路  7Comments  路  Source: golang/protobuf

We intend to hand off ownership of protoc-gen-go-grpc to the google.golang.org/grpc project. This issue tracks coordination between google.golang.org/protobuf and google.golang.org/grpc to accomplish this.

Most helpful comment

The current error message produced by protoc-gen-go is unhelpful for users since protoc-gen-go-grpc doesn't exist yet.

We should update that message to point to the updated gRPC documentation when it's ready.

cc @merovius

All 7 comments

Note to self: we need to port the unimplemented server types to the new implementation.

This still needs to happen, but probably after the first rc1 release.

The logic has been moved to be an internal package of v1. Moving to grpc can happen shortly after but doesnt block release.

Did I miss this in the release notes? I wanted to try new v2 protobuf implementation today, but cannot because of the missing protoc-gen-go-grpc. Is there any ETA for the generator in the google.golang.org/grpc module?

Adding a generator to the gRPC module is in progress; for now, you can use github.com/golang/protobuf/protoc-gen-go at version v1.4.0-rc.2 or later, which includes an integrated version of the gRPC generator as before.

The current error message produced by protoc-gen-go is unhelpful for users since protoc-gen-go-grpc doesn't exist yet.

We should update that message to point to the updated gRPC documentation when it's ready.

cc @merovius

Was this page helpful?
0 / 5 - 0 ratings

Related issues

kevinburkemeter picture kevinburkemeter  路  18Comments

mwitkow picture mwitkow  路  14Comments

bcmills picture bcmills  路  29Comments

jney picture jney  路  15Comments

bufdev picture bufdev  路  18Comments