Prometheus-operator: Generated copyright headers always use 2018 as copyright year
This came up in a code review with @lilic here: https://github.com/prometheus-operator/prometheus-operator/pull/3451#discussion_r493294089.
See here for where the value comes from.
This means that when we run generation commands, the year is always set to 2018, even for newly-generated files.
Should we update this to 2020, meaning that all generated files will have 2020 in the copyright header? What about manually-created files?
grdryn
>All comments
I'd say we should follow what Kubernetes is doing, aka removing the YEAR for the generated go files: https://github.com/kubernetes/kubernetes/blob/master/hack/boilerplate/boilerplate.generatego.txt
As for the files created manually, we should continue with the usual mechanism to set the YEAR according to the one the file was created at.
dgrisonnet
on 25 Sep 2020
Related issues
tsloughter
路
3Comments
cyrus-mc
路
3Comments
r-moiseev
路
3Comments
xinau
路
3Comments
Hashfyre
路
3Comments
Most helpful comment
I'd say we should follow what Kubernetes is doing, aka removing the YEAR for the generated go files: https://github.com/kubernetes/kubernetes/blob/master/hack/boilerplate/boilerplate.generatego.txt
As for the files created manually, we should continue with the usual mechanism to set the YEAR according to the one the file was created at.