Project-system: Append "Windows Forms" and "WPF" suffix to file templates & menus

[davkean]

Now that Windows Forms and WPF can be combined in the same project type, we should add suffix differentiators to differentiate the technologies:

Proposal is to change the menus and template names to append the appropriate tech:

Current Template|Current Menu|New Template Name|New Menu Name
---|---|---|---
Inherited Form|N/A|Inherited Form (Windows Forms)|N/A
Inherited User Control|N/A|Inherited User Control (Windows Forms)|N/A
Window Form|Windows Form...|Form (Windows Forms)|Form (Windows Forms)...
User Control|User Control...|User Control (Windows Forms)|User Control (Windows Forms)...
About Box|N/A|About Box (Windows Forms)|N/A
Custom Control|N/A|Custom Control (Windows Forms)|N/A
MDI Parent Form|N/A|MDI Parent Form (Windows Forms)|N/A
Window (WPF)|Window...|Window (WPF)|Window (WPF)...
Page (WPF)|Page...|Page (WPF)|Page (WPF)...
User Control (WPF)|User Control...|User Control (WPF)|User Control (WPF)...
Resource Dictionary (WPF)|Resource Dictionary...|Resource Dictionary (WPF)|Resource Dictionary (WPF)...

AB#825237

[jmarolf]

fixed with AB#187828

[davidwengier]

This is related to AB#825237

[davkean]

@jmarolf Reopening this, this looks great with exception to WIndows Forms, it looks like Update 2 wasn't merged: https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/187828?_a=files&iteration=2&base=1.

[jmarolf]

I don't know if I see the sense is writing Windows Form (Windows Form). How does repeating yourself give the user more actionable information than the single Windows Form?

[davkean]

As per above and PR it was Form (Windows Forms). Now the "Windows Forms" looks out of place with the other templates. It's not repeating, it's a Form from the technology Windows Forms, just like its a Window from the technology Windows Presentation Framework

[davkean]

@jmarolf I see you updated C# here: https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/191489?path=%2Fsrc%2Fvsproject%2Fcool%2Fcoolpkg%2Fpkgui%2Fcoolpkgui.rc&_a=files, but not VB. Was there a reason for that?

[davkean]

Oh, may be VB is okay:

And only add item needed to be updated which is shared between C# and VB?

[davkean]

Although in saying that Splash Screen isn't updated, which was also called out:

[jmarolf]

@davkean sorry, I somehow missed the conversation on splash screen. Is there anything else I am missing from this table https://github.com/dotnet/project-system/issues/4936#issue-458364676? I'll send a mop-up pr shortly

[davkean]

It looks like only splash screen.

[jmarolf]

Should all be resolved with AB#191747