Project-system: Resx files are not generated in the design time build

[jmarolf]

1. Create a new dotnet core Console Application
2. Add a Resource file and create a string named String1
   
3. Go and use Resource1.String1 in a code file.
   

Expected: resx file tools are run and String1 property is generated

Actual: Project needs to be rebuilt for resx files to generate

[davkean]

This isn't design-time build, but rather the single file generator getting run.

I cannot repro this - do you have a consistent repro? If so, can you add the exactly steps (including what windows have focus)?

[jmarolf]

@davkean you see no errors at all? which build are you on?

[davkean]

Yesterdays

[jmarolf]

@davkean http://recordit.co/5QFcOkeHAk

[jmarolf]

[davkean]

Thanks - that's a great way to show me, upgrading to today's and trying again.

[davkean]

Okay, I can repro this now. It appears we are not running the SingleFileGenerator when we switch docs, which I thought was supposed to happen. Interestingly enough, if I open the Designer file, the generation occurs. Building also doesn't cause it to generate.

[davkean]

Looks like we don't run these when changing the default namespace either: https://github.com/dotnet/project-system/issues/1933.

[davkean]

Going to give this one to you Jon, I've got too much on my plate for 15.3.

[davkean]

We should figure out when the legacy project system runs these and run them at the same time.

[jmarolf]

NOTE: be sure to test case mentioned in #1845 when verifying this fix

[jmarolf]

Looking at our code we seem to be hooking everything up correctly for single file generators, @lifengl is there a good way for a consumer of CPS to modify when single file generators are run?

[davkean]

Make sure you also try: ~#1521~ https://github.com/dotnet/project-system/issues/2446

[jamesqo]

@davkean You linked back to the same issue; I think you meant #2446.

[davkean]

@jamesqo Thanks, you would not believe how many times I do that.

[jmarolf]

Tracked in CPS with 453823

[davkean]

This isn't happening because the generator isn't running. This is happening because CPS is turning off change tracking for the generated file while it writes it to disk, causing Roslyn to not see/pick up the changes.