Project-system: We should hide the Assemblies tab for .NET Core apps

Created on 27 Aug 2016  路  15Comments  路  Source: dotnet/project-system

image

Bug

Most helpful comment

image
in .Net 4.6 tab we show assemblies to be selected, however if .NetCoreApp is selected - it does not display any assemblies

All 15 comments

This should be hidden behind a capability for desktop support.

Blocked by CPS, AssemblyReference, which is the capability used to block the this tab is used for other things and removing it results in a CPS load failure.

I'm not sure AssemblyReference is the right capability here, we support assembly references, just not from framework or extension locations.

Agreed, however that's one of the extensibility issues with CPS I mentioned offline. Currently this is the only way to control the tabs. We're having a separate conversation about changes needed to support the right extensibility points.

Are references of this type ok within an ItemGroup with Condition="$(TargetFramework) == 'net461'"?

Yes, and we'll let you consume when targeting .NET Framework.

To clarify, if my project has a target net461, how do i add a framework assembly reference if we would hide that tab in Add Reference dialog?

I'm a bit fuzzy on the high level picture, if your project is targeting 4.6.1 it wouldn't be pulling in the .Net Core SDK right? If that is the case then you'll still get the tab on the reference manager since it would be the SDK targets that force it to be gone. If that is not the case lets chat.

The capabilities will be/should be set based on the target framework in the SDK. When targeting .NET 4.6.1, the capability will be present (or not present).

What we don't have, is a good experience when you target both - we're basically going to pick the TFM that is first listed as the "current TFM" - that will dictate whether it shows up or not.

Sounds ok, as long as there aren't conflicting capabilities which mean we have to swap the order back and forth.. X(

@davkean Yes, i was more interested in the scenario when we have both - taking first TFM will look confusing ...

@abpiskunov Until we can update the rest of VS to understand multiple TFMs - what's your alternative?

In dnx/dotnet project system we provided our own implementation of Assemblies tab provider , that allowed adding assemblies only for full framework targets. We had another level of targets under Assemblies tab for each project TFM and displayed assemblies to be selected only for full desktop tfms.

Can you post a screen shot? I don't the bits installed.

image
in .Net 4.6 tab we show assemblies to be selected, however if .NetCoreApp is selected - it does not display any assemblies

Was this page helpful?
0 / 5 - 0 ratings