Products.cmfplone: Content Type Icons no longer displayed in 5.2.2rc3

[pbauer]

https://github.com/plone/mockup/pull/1003/files#diff-a6b31c800683d65906ffb168530bb2aaL364 introduced a regression.
In the add-menu content-type icons are no longer displayed:

Before:

After:

[vincentfretin]

I'll look into it today.

[vincentfretin]

Note, before my change, we had the issue only on Safari, because &:not(.plone-toolbar-submenu-header, .plonetoolbar-display-view.actionSeparator) rule was evaluated, and not in other browsers.

[vincentfretin]

&:not(.plone-toolbar-submenu-header, .plonetoolbar-contenttype) would fix it but it's only supported on Safari, not on Chrome and Firefox. I thought about adding additional rules to override what is in &:not(.plone-toolbar-submenu-header) but the icon defined with :before {content: ...} in plonetheme/barceloneta/theme/less/contents.plone.less is already lost with the not: rule that redefine the content.
The only way I think of is instead of the rule

        &:not(.plone-toolbar-submenu-header)

add explicitly all submenus where we want the bullet point.

        &.plonetoolbar-workfow-transition,                                         
        &.plonetoolbar-content-action,                                          
        &.plonetoolbar-display-view,                                            
        &.plonetoolbar-portlet-manager,                                         
        &.user-action 

This seems to work.

[vincentfretin]

I fixed it in https://github.com/plone/mockup/pull/1003

[mauritsvanrees]

FTR, fixed in https://github.com/plone/mockup/pull/1009, not 1003.