Problem-specifications: Rename resistor-colors

Created on 2 Apr 2019  路  16Comments  路  Source: exercism/problem-specifications

Hello :)

We have two new exercises:

  • resistor-color
  • resistor-colors

I'm uncomfortable with how close the names are. It is marginally confusing generally, and for someone less familiar with English, I think just having the s changed is not enough.

I propose renaming the second exercise to resistor-color-pairs. I'm not attached to that, but I just want some proposal down as a default if no-one can come up with anything better :)

Once this is agreed, I'll merge https://github.com/exercism/website-icons/issues/25

(cc @F3PiX @ErikSchierboom who came up with the exercise)

Most helpful comment

So I think it's these tracks. Sample PR is here.

  • [x] Python (cc @exercism/python)
  • [x] Haskell (cc @exercism/haskell)
  • [x] JavaScript (cc @exercism/javascript)
  • [x] Pharo (cc @exercism/pharo-smalltalk )
  • [x] Ruby (cc @exercism/ruby )

Maintainers: Tick yours off when done :)

All 16 comments

I understand the confusion. Personally, I don't have a preference for any other name, so I'll leave that to @F3PiX :)

I agree it's confusing. I'm looking ahead at the rest of the series, and it would be best if the sequence is clear, looking only at the names.
Therefore I'd prefer to change both names:

  • Resistor Color -> Resistor Single Color
  • Resistor Colors -> Resistor Color Duo (for people knowing Resistors "pairs" is probably confusing.)

The next will be about, you guess that, 3 colors, so that can be Restistor Color Trio, or something else that indicates 3.

How about this?

I like "Resistor Color Duo" and "Resistor Color Trio" but I think "Resistor Single Color" is a little functional. I'd happily just leave that as "Resistor Color" and change the others as you suggested.

I'd also rather not change the first as it's live exercise on lots of tracks, so renaming it now is hard.

This seems to be positively recieved. Presuming there's no objections, could we get resistor-colors聽changed to resistor-color-duo on the tracks that have implemented it pls (just change the title and slug, but not the uuid) and I'll get the icon merged :)

I created #1502 for this.

Also, Python track implementation has been renamed. I regenerated the README using the changes made in #1502.

So I think it's these tracks. Sample PR is here.

  • [x] Python (cc @exercism/python)
  • [x] Haskell (cc @exercism/haskell)
  • [x] JavaScript (cc @exercism/javascript)
  • [x] Pharo (cc @exercism/pharo-smalltalk )
  • [x] Ruby (cc @exercism/ruby )

Maintainers: Tick yours off when done :)

Maintainers: don't forget to update website-copy if you have mentor notes already.

I like "Resistor Color Duo" and "Resistor Color Trio" but I think "Resistor Single Color" is a little functional. I'd happily just leave that as "Resistor Color" and change the others as you suggested.

Though there may be some value in doing so as it does hint to those that may feel like expanding on the color exercise that there are more coming up, or even to limit it (for some unknown reason) to a single color.

Process question: what should be merged first? The problem specifications PR (#1502) or the Track updates? I'm holding off merging my Ruby track changes because they refer to the specific commit on #1502 (8b44ce1) in this line.

So it seems to make sense to merge #1502 beforehand, right?

cc @kytrinyx

Correct. Update problem specification first.

There's an issue in Javascript https://github.com/exercism/javascript/issues/664 with the renaming. PR for the change: https://github.com/exercism/javascript/pull/662/files Can someone help me figure out what's the issue here?

@tejasbubane I have the same as you: no error for me. Perhaps propagation / caching issue?

Did I accidently close this - by referencing it (I think it stays open for Haskell)?

Haskell is done. So I guess this can be closed now.

Thanks y'all!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

wolf99 picture wolf99  路  4Comments

kytrinyx picture kytrinyx  路  5Comments

kytrinyx picture kytrinyx  路  4Comments

kytrinyx picture kytrinyx  路  5Comments

budmc29 picture budmc29  路  3Comments