Privacybadger: clients6.google.com

[terrorist96]

https://liberland.org/en/news/

clients6.google.com breaks calendar.

[ghostwords]

More examples:

• https://www.teamunify.com/SubTabGeneric.jsp?team=csfcast&_stabid_=111577
• http://techshop.ws/calendars.html?storeId=5&calendar=102
• https://wildlife.utah.gov/calendar.html
• http://speedgaming.org/schedule/
• https://belltowercommunitycenter.com/calendar/
• http://www.musique-sacree-notredamedeparis.fr/audition-grand-orgue
• https://www.senderoneclimbing.com/lax/classes/yoga-and-fitness/
• https://www.conejovalleyguide.com/events-calendar/
• http://londontangocalendar.blogspot.co.uk/

[terrorist96]

@ghostwords it's being blocked again despite being on the yellowlist.
https://liberland.org/en/news/

**** ACTION_MAP for clients6.google.com
VM719:5 clients6.google.com {
  "userAction": "",
  "dnt": false,
  "heuristicAction": "",
  "nextUpdateTime": 1506692286618
}
VM719:7 **** SNITCH_MAP for clients6.google.com

[ghostwords]

The yellowlist update containing clients6.google.com went out on September 5th. I have not seen any error reports for clients6.google.com since then.

Your heuristicAction should be "cookieblock", not "" ... How did your Badger get into this state? Do you remember if clients6.google.com got cookieblocked for you after the yellowlist update?

[terrorist96]

Yes, I remember seeing it get cookie blocked. But for some reason, it's back to red now. Strange...

[ghostwords]

I'll try to reproduce. #1690 is possibly related since media.readthedocs.org is on the yellowlist, but the user reports it as blocked.

[terrorist96]

Thanks. Can you reopen this for the time being?

[ghostwords]

OK, I can reproduce by importing a profile that learned to block google.com but doesn't yet know about clients6.google.com, visiting a few sites with embedded calendars (https://github.com/EFForg/privacybadger/issues/1588#issuecomment-325510757) and seeing clients6.google.com become blocked instead of cookieblocked.

Let me see what the bug is. I'll probably open a new issue then.

[ghostwords]

I think the reason we don't see this issue much is that you are only affected if you learned to block google.com before we had clients6.google.com in the yellowlist, and you somehow bypassed the yellowlist update code that kicks in when you get the yellowlist update containing clients6.google.com and your Badger knows to block google.com ...

Wait a second, is this an Export/Import User Data bug? Your Badger has the latest yellowlist but doesn't yet know to block google.com, and you import data that teaches Badger to block google.com, but importing fails to mark all yellowlisted google.com subdomains as cookieblocked.

[terrorist96]

No, I didn't import an old profile. It's my same/current profile. But yeah, I'm not sure. Whenever you guys fix one of my reports, I always remember to come back to check to see that it's actually been fixed when the next version of PB is released. And this issue was fixed. But then it learned to block it again for some reason.

[ghostwords]

Could you run our debugging code for "google"? I'm interested in seeing your action_map entries for all google.com domains.

[terrorist96]

Action map sent to your email.

[ghostwords]

So it's not just clients6.google.com that's weird. All of these subdomains are on the yellowlist, but are not set to "cookieblock" in your action_map:

Missing:

• books.google.com

Set to "":

• clients6.google.com
• fusiontables.google.com
• trends.google.com
• video.google.com

Set to "block":

• play.google.com
• sites.google.com

[ghostwords]

Which domains do you see printed when you run the following on Badger's background page?

(function () {
  let am = badger.storage.getBadgerStorageObject('action_map'),
    ylist = badger.storage.getBadgerStorageObject('cookieblock_list').getItemClones();
  for (let domain in ylist) {
    let base = window.getBaseDomain(domain);
    if (base != domain && am.getItem(base) && am.getItem(base).heuristicAction == "block" && am.getItem(domain) && am.getItem(domain).heuristicAction != "cookieblock") {
      console.log(domain);
    }
  }
}());

This looks for all non-cookieblocked subdomains on the yellowlist whose base domains are blocked. (Such subdomains should all be cookieblocked, I think.)

[terrorist96]

VM888:7 clients6.google.com
VM888:7 content.jwplatform.com
VM888:7 fusiontables.google.com
VM888:7 play.google.com
VM888:7 sites.google.com
VM888:7 trends.google.com
VM888:7 video.google.com