Prisma1: Deploy issues with 1.25

[yukulelix]

Description of the bug
Since 1.25 update, I can't deploy anymore. The error I get is Cannot read property 'steps' of null. From what I can tell, it comes from deploy.js within prisma-cli-core package. Any chance you could help on this ?

To Reproduce
Steps to reproduce the behavior:

1. Update to 1.25
2. Perform a prisma deploy

[divyenduz]

@yukulelix : Can you please share your Prisma CLI version via prisma --version

[divyenduz]

I suspect that you are on the latest server version but an older CLI version. Ideally, they should be on the same version. Would it be possible for you to update the CLI to latest version if that is the case indeed.

You can do so via npm install -g prisma or brew install prisma

[nunsie]

Also getting the same error on freshly installed prisma v1.25.0
Error log output:

TypeError: Cannot read property 'steps' of null
    at Deploy.printResult (/usr/local/lib/node_modules/prisma/node_modules/prisma-cli-core/src/commands/deploy/deploy.ts:477:54)
    at Deploy.<anonymous> (/usr/local/lib/node_modules/prisma/node_modules/prisma-cli-core/src/commands/deploy/deploy.ts:258:10)
    at step (/usr/local/lib/node_modules/prisma/node_modules/prisma-cli-core/dist/commands/deploy/deploy.js:45:23)
    at Object.next (/usr/local/lib/node_modules/prisma/node_modules/prisma-cli-core/dist/commands/deploy/deploy.js:26:53)
    at fulfilled (/usr/local/lib/node_modules/prisma/node_modules/prisma-cli-core/dist/commands/deploy/deploy.js:17:58)
    at <anonymous>
    at process._tickDomainCallback (internal/process/next_tick.js:229:7)
  util timed out +0ms

[nunsie]

My current workaround is npm i -g [email protected]

[divyenduz]

@nunsie : Can you please share your Prisma server version as well? Thanks!

[nunsie]

Sure thing @divyenduz
prismagraphql/prisma:1.24

[divyenduz]

Got it, so, older Prisma server (1.24) version and newer CLI (1.25) fails to work. Trying a reproduction now.

[divyenduz]

I am unable to reproduce this with Prisma server version 1.24 and CLI version 1.25. Can you please provide more information (maybe the datamodel) or a reproduction repository?

[pantharshit00]

I am able to confirm this @divyenduz. This only happens when there is no change in the datamodel and it throws this error instead of notifying us that the service is already up to date.

Quick repro

1. Clone: https://github.com/baby1990/test-graphql-shield
2. Change version to 1.24 in the compose file
3. Launch the cluster
4. run prisma deploy twice

[divyenduz]

This is resolved in the latest beta of CLI ([email protected]) npm install -g prisma@beta

Please give it a go and let me know if the issue still exists. Thanks.

[jiaxi0713]

@divyenduz : I've updated prisma to 1.25.1 and this issue still occurs while I exec prisma deploy with no change in my datamodel.

[divyenduz]

@jiaxi0713: this fix is not yet available in stable, can you please try it with the latest beta and let me know?

[xontik]

Hello !
Same bug on 1.25.1, I can confirm last beta fixed it

[divyenduz]

This is now available on all release channels, including the latest stable at 1.25.3, please give it a go via npm install -g prisma and let me know if there are any hiccups via comment. Thanks.