Prisma1: Add integration tests

Created on 10 Nov 2018  路  3Comments  路  Source: prisma/prisma1

A lot of developers have problems with broken prisma-clients sometimes because there are no integration tests which will check if the generated prisma-client actually works.

We created this ticket because we had some problems and discussed possibilities to prevent those problems in the future.

The solution

The best solution would be to add integration test. These tests should include generating a prisma-client based on a more complex schema.graphql like in this project. After that the prisma-client should be successfully compiled. The test should fail when the compilation fails.

@divyenduz also recommended one thing we can also do:

we should add executing operations against a live Prisma service in the test suite to test prisma-client-lib part

kinfeature areclient

Most helpful comment

Thanks a lot for bringing this up @sapkra ! We're sorry about this and are not happy with the quality, that we put up with the client right now. We're working on better tests for the Client in the coming week. Stay tuned. We'll keep this issue open for now until we have a substantially better test setup than now and have fixed the major issues in the client.

All 3 comments

Thanks a lot for bringing this up @sapkra ! We're sorry about this and are not happy with the quality, that we put up with the client right now. We're working on better tests for the Client in the coming week. Stay tuned. We'll keep this issue open for now until we have a substantially better test setup than now and have fixed the major issues in the client.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

Added feature label to avoid stalebot

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ragnorc picture ragnorc  路  3Comments

MitkoTschimev picture MitkoTschimev  路  3Comments

nikolasburk picture nikolasburk  路  3Comments

dohomi picture dohomi  路  3Comments

AlessandroAnnini picture AlessandroAnnini  路  3Comments