Prisma1: Multiple identical subscriptions on CREATE

[Fi1osof]

Current behavior
Prisma local send duplcate subscriptions.

Reproduction
Open more than 2 playground and start same subscription requests and send create request.

For 3 connections receive three notifications in each window. For 5 - 5 notifications in each window. And etc...

Expected behavior?
One notification per one ws-connection.

[oxy88]

Same

[marktani]

Are you experiencing this when connecting directly to your Prisma endpoint, or when connecting indirectly via another GraphQL Server?

[Fi1osof]

@marktani i do not us another GraphQL server. I use prisma local. But this problem i have when connect via appolo-client too. In termanal logs i receive multiple notifications too.

[flintc]

@marktani If I understand correctly, I am only seeing this issue when connecting indirectly via graphql-yoga GraphQLServer. Running graphql playground I can test subscriptions on the database and application side. The multiple firings only occur on the app side. Each message is sent to each client multiple times equal to the number of clients that have connected since starting the server. Subscriptions in graphql-yoga that don’t use prisma-bindings work as expected.

[flintc]

Perhaps this is due to the fact that graphql-yoga (or any other server) acts as a proxy server when used with prisma. Browser connections would be made with the proxy server, not the prisma endpoint. When the browser is closed, the underlying prisma server is unaware and continues to try and send messages to these ghost clients. This would explain why there is no issue with subscriptions made directly with the prisma endpoint. And also why there is no issue with graphql-yoga subscriptions that don't rely on prisma.

[Fi1osof]

@flintc i agree

[oiojin831]

I have this problem with react-native. Does anyone know how to solve this problem?

[oiojin831]

Isn't this related to this issue?
https://github.com/graphcool/graphql-yoga/issues/101#event-1458329589

[marktani]

@oiojin831 did you try upgrading your versions as discussed in the link you mentioned?

[oiojin831]

@marktani Yes, this is not a problem for me anymore.
I was mentioning this cause I thought this can be closed 😄

[marktani]

Hey @oiojin831, that's what I thought 🙂 Thanks for the confirmation!

@Fi1osof, I'm closing this issue as it seems resolved, please open another one if you're still encountering any problems!

[ramsaylanier]

@marktani So, I was having this issue as well, where I would create an item and the subscription would update the query multiple times. Its seems this issue has been fixed (meaning that the query is only updated once) but when I'm logging all the queries, I still see "mutation: CREATED" an increasing number of times until I do a browser refresh.

Here's the mutation in playground.

Here's the subscription in playground. It only gets one response.

HOWEVER, here is what is logged to the terminal. This is after creating several rules.

So, I'm concerned this is still an issue.

[pungggi]

yes still an issue