Current behavior
When requested the 'hello(name)' function returns null
Reproduction
Request:
query {
hello(name:"TEST") {
message
}
}
Result:
{
"data": {
"hello": null
}
}
Expected behavior?
Should result in:
{
"data": {
"hello": {message: "Hello TEST"}
}
}
Hey @rollinball, I just did the following with [email protected] and could not reproduce the problem:
graphcool init
graphcool deploy
This hello query works as expected:
query {
hello {
message
}
}
{
"data": {
"hello": {
"message": "Hello World"
}
}
}
Can you please include more information that helps reproduce this? Can you paste the output of graphcool version, too?
Also, please use code snippets, that makes it a lot easier to read your code.
hi Mark
thanks for the reply.
well if i do just what you did:
graphcool init test
cd test
graphcool deploy
Then on playground i do
query {
hello {
message
}
}
I hit play
and I get
{
"data": {
"hello": null
}
}
graphcool version
graphcool/0.7.0 (windows-x64) node-v6.11.4
I'm on Win 10.
Hey there, I'm pretty sure you were running into this: https://github.com/graphcool/graphcool/issues/896
Can you confirm?
By the way, I'm Nilan, not Mark 馃槃
Hi Nilan,
Sorry about that, I myself do return null sometimes, those new technologies are very disturbing.
here is my log:
returnValue":{"errorMessage":"Cannot find module '/var/task/src\\hello-lambda'","errorType":"Error","stackTrace":["Function.Module._load (module.js:417:25)","Module.require (module.js:497:17)","require (internal/module.js:20:19)"]}}
notice also the \ in the path coming from win.
Just tested on linux and it works.
I tried to git clone the project I initally graphcooled init on Win, on Linux then redeploy it from linux and the problem was still there. I had to graphcool init a new project from linux and then copy the .graphcoolrc to my former project, graphcool deploy my former project from linux and there it worked.
It doesnt seem to be related to the bug #896 .
ps: How do you bill functions, do you bill the execution time? On the logs of the hello function the duration says 370ms wich clearly include the request, whereas I doubt the function takes more than 1ms to execute, how do you bill that?
Bumping this up! I'm getting the same issue :)
I can confirm that the deploy is still not working on Windows with the error from https://github.com/graphcool/graphcool/issues/885#issuecomment-337814173.
Can we update the title to 'Deploy not working on Windows' and add a 'breaking' label?
'Deploy not working on Windows'
We identified a couple of issues (see https://github.com/graphcool/graphcool/labels/theme%2Fcli-windows and more that are not documented yet) and will add windows support soon. It will probably be released sometime leading up to version 0.10.
and add a 'breaking' label?
Side question, why is this breaking?
Side question, why is this breaking?
Because deploy on Windows is no longer possible in the _released_ Framework Preview version? That was fine when it was still alpha, but the new function deployment is released as @next.
Before, it was just gc local that didn't work on Windows, but now, deploy is not working anymore either.
The breaking label signifies that adding the feature or fixing the bug is a breaking change.
The breaking label does not signify a 'regression' or the introduction of new bugs.
This issue is not a breaking change, it's a feature request that can be added additively. We'll add explicit support for Windows soon, as mentioned above. 馃檪
Okay, so I was wrong about the breaking label, but deployment on Windows stopped working with the introduction of AWS for running functions. I don't understand why that gets labeled as 0.10. And seriously, don't turn a bug into a feature request?!
Hope this can be fixed really soon! It's put me at a stand still for doing anything function related via the cli :)
@marktani any way this can be bumped up to 0.9?
Update, as Windows deployment is still not working. Developers that use Windows 10 can take advantage of a feature called 'Windows Subsystem for Linux'. It basically runs a native Linux bash shell, with your Windows filesystem mounted. So you can easily use that shell to deploy.
This is now released in 0.9.1: https://github.com/graphcool/framework/releases/tag/0.9.1 馃檪
Most helpful comment
Okay, so I was wrong about the
breakinglabel, but deployment on Windows stopped working with the introduction of AWS for running functions. I don't understand why that gets labeled as 0.10. And seriously, don't turn a bug into a feature request?!