Print.js: dist/print.js is bloated with eval()
In 1.0.63, code in dist/print.js ( see from unpkg ) contains eval().
It seems some build settings of Webpack might be inaccurate for distribution build.
help wanted
maisumakun
All 5 comments
Hey @maisumakun, this doesn't sound good. I'll take a look at it. Any ideas on how we can fix this?
crabbly
on 20 Nov 2019
@crabbly did you run npm run production for 1.063 or npm run dev? eval must be coming from the dev build
natalan
on 22 Nov 2019
Anyway, I just submitted a PR here to set devtool to source-map in dev builds. #392
natalan
on 22 Nov 2019
Sorry for the delay guys. @natalan I thought I used the production flag. But maybe I messed this up.
I just merged your PR. Will run a few manual tests and try to publish a new version as soon as possible.
crabbly
on 26 Dec 2019
👍2
Closing this since these changes were deployed to npm. Latest version is currently v1.1.0. Thank you.
crabbly
on 5 Sep 2020
Was this page helpful?
0 / 5 - 0 ratings
Related issues
GuoSirius
·
8Comments
r3wt
·
8Comments
deysudip
·
4Comments
galcott
·
7Comments
Orcinuss
·
8Comments
Most helpful comment
Sorry for the delay guys. @natalan I thought I used the
productionflag. But maybe I messed this up.I just merged your PR. Will run a few manual tests and try to publish a new version as soon as possible.