Primeng: Bug in confirmation dialog

Created on 10 Jun 2020  路  13Comments  路  Source: primefaces/primeng

I'm having some problem with CONFIRMATION DIALOG component after I build the project. It just stays really bugged, the background doesn't show up, only the confirmation element.
The weird thing is that it works perfectly in development.
So I went to the element in development mode and noticed that the following classes are not being applied after the build:

ng-star-inserted ui-widget-overlay ui-dialog-mask ui-dialog-visible ui-dialog-mask-scrollblocker.

While inspecting the built project, if I insert these classes in the \

COMMIT WHERE I'M USING IT

Current behavior
Confirm dialog background not showing up !

Please tell us about your environment:
Windows 10

  • Angular version: 9

  • PrimeNG version: 9.1.0

  • Browser: Chrome

  • Node (for AoT issues): node --version = 10.15.0

Most helpful comment

BUG 2: acceptLabel, rejectLabel etc. do not work any more...

Refactoring and no unit tests are not the best solution :/

All 13 comments

BUG 2: acceptLabel, rejectLabel etc. do not work any more...

Refactoring and no unit tests are not the best solution :/

Maybe something with this function ??

The complete footer-template-part is not called for option replaces. Example: acceptLabel: 'test' -> option('acceptLabel') will return 'Yes'

Not sure about real cause of the issue, but it reproduces when ivy is enabled.
To make it work, as quick fix, one should disable ivy or enable prod mode

Similar issue is reported in https://github.com/primefaces/primeng/issues/8823 and https://github.com/primefaces/primeng/issues/8724

Also I've noticed that ivy is disabled for primeng by default. Although they might enable it during a build of showcase

The issue is still here on 10.0.0.rc1, in showcase

if an application uses Ivy then the fix shouldn't be disabling it, but fixing the dialog itself. Ivy is enabled for a reason.

Any progress on this bug? Will this be fixed for previous versions? Or is there going to be a workaround?

Any progress on this bug? Will this be fixed for previous versions? Or is there going to be a workaround?

@MiRush94 as I've mentioned above
I've fixed it for my project by enabling production for all my builds, although it's not very convenient

yeah that doesn't really work for me, I was hoping for a fix from primeNG itself :S

I've stopped the project for a while after I reported this. I still can't believe that after so many people reporting the same problem it still hasn't been fixed.

I've stopped the project for a while after I reported this. I still can't believe that after so many people reporting the same problem it still hasn't been fixed.

Yeah it is quiet a shame...

Unable to replicate with PrimeNG 11.0.0-rc.1, if the issue persists please create a new ticket with a test case reproducing the issue e.g. stackblitz or a github repo and it will be reviewed by our team once again.

Was this page helpful?
0 / 5 - 0 ratings