Primeng: Editor has stopped working after upgrade to primeng 8.0.0-rc.1

[fernandogomesdf]

Editor has stopped working after upgrade to primeng 8.0.0-rc.1

ng:///ComponentesModule/CriareventoComponent.ngfactory.js:339 ERROR TypeError: quill_1.default is not a constructor
at Editor.push../node_modules/primeng/components/editor/editor.js.Editor.ngAfterViewInit (vendor.js:171549)
at callProviderLifecycles (vendor.js:74555)
at callElementProvidersLifecycles (vendor.js:74520)
at callLifecycleHooksChildrenFirst (vendor.js:74502)
at checkAndUpdateView (vendor.js:84713)
at callViewAction (vendor.js:85069)
at execComponentViewsAction (vendor.js:84997)
at checkAndUpdateView (vendor.js:84710)
at callViewAction (vendor.js:85069)
at execComponentViewsAction (vendor.js:84997)

With angular 8.0.0 and primeng 7.1.3 it works fine.

My code:
https://github.com/fernandogomesdf/rennova-web.git
(disable login guard)

Any suggestions?

[marten-nilsson]

Angular 8.0.0
primeng 8.0.0-rc.1

TypeError: quill_1.default is not a constructor
at Editor.push../node_modules/primeng/components/editor/editor.js.Editor.ngAfterViewInit (vendor.js:225551)
at callProviderLifecycles (vendor.js:86238)
at callElementProvidersLifecycles (vendor.js:86212)
at callLifecycleHooksChildrenFirst (vendor.js:86202)
at checkAndUpdateView (vendor.js:94132)
at callViewAction (vendor.js:94364)
at execComponentViewsAction (vendor.js:94306)
at checkAndUpdateView (vendor.js:94129)
at callViewAction (vendor.js:94364)
at execEmbeddedViewsAction (vendor.js:94327)
at checkAndUpdateView (vendor.js:94124)
at callViewAction (vendor.js:94364)
at execEmbeddedViewsAction (vendor.js:94327)
at checkAndUpdateView (vendor.js:94124)
at callViewAction (vendor.js:94364)

[McGiogen]

~Source code is correct~ but not the distributed code ( this.quill = new quill_1.default(editorElement, { ). Manually executing the following code works:

this.quill = new quill_1(editorElement, {
            modules: modules,
            placeholder: this.placeholder,
            readOnly: this.readonly,
            theme: 'snow',
            formats: this.formats,
            bounds: this.bounds,
            debug: this.debug,
            scrollingContainer: this.scrollingContainer
        });

[cagataycivici]

I'm unable to replicate with the latest PrimeNG. If the issue still persists with the new version please create a new issue with a stackblitz template that demontrates the problem.

Live demo also runs on 8

[dmastag]

Hi @cagataycivici
Here is the Stackblitz with the same exact error

https://stackblitz.com/edit/angular-nzene1

Its using Angular 8 and primeng 8.0.0-rc.1

[dmastag]

I was changing the source in
node_modules/primeng/components/editor/src/app/components/editor/editor.js

from

this.quill = new quill_1.default(editorElement, {

into

this.quill = new quill_1(editorElement, {

And got it working, which is weird

[dmastag]

@cagataycivici
Tried with the latest 8.0.0 Release

https://stackblitz.com/edit/angular-u48wcb
Still not working

All, do I need to open a new Ticket since this one has been Closed by @cagataycivici ?

[dmastag]

New update
I tried to update my project that had the problem from [email protected] to [email protected]
And the issue went away

Though it is not working on the stackblitz I sent earlier.

@fernandogomesdf @Vendium @McGiogen
Would you mind to test also ?

[EngAhmedShehatah]

I have the same error in a project of mine

The output of ng version is :
Angular CLI: 8.0.2
Node: 12.4.0
OS: linux x64
Angular: 8.0.0
... animations, cdk, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package Version

@angular-devkit/architect 0.800.2
@angular-devkit/build-angular 0.800.2
@angular-devkit/build-optimizer 0.800.2
@angular-devkit/build-webpack 0.800.2
@angular-devkit/core 8.0.2
@angular-devkit/schematics 8.0.2
@angular/cli 8.0.2
@angular/http 7.2.15
@ngtools/webpack 8.0.2
@schematics/angular 8.0.2
@schematics/update 0.800.2
rxjs 6.5.2
typescript 3.4.5
webpack 4.30.0

---

I am using charts in my projects as well, when I install [email protected], the charts had been corrupted with ugly background. On the previous solution of modifying the editor/editor.js file, the charts and everything else is working fine in my project.

So, I don't think that the perfect solution is to remove [email protected] and install [email protected] instead.