Primeng: Clicking close icon on the Confirm dialog is invoking reject action

Created on 11 Oct 2018  路  4Comments  路  Source: primefaces/primeng

This is a reported and closed (by telling should work on 4.2.2) issue on link, one year ago. Same issue still exists, unfortunately.

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
When using confirm dialog clicking on close icon is taking the action as reject.

Expected behavior
It should just close the confirm dialog.

Minimal reproduction of the problem with instructions
The behaviour can be seen in your showcase link below. clicking close icon takes the action as reject.
https://www.primefaces.org/primeng/#/confirmdialog

What is the motivation / use case for changing the behavior?
For Yes/No/Cancel scenarios.

  • Angular version: 6.1.1

  • PrimeNG version: 6.1.2

  • Browser: [all]

enhancement

Most helpful comment

Unnecessary logic on a neutral action. Allow users to override this logic with extra parameters, at the very least.

All 4 comments

I think it is by design, we had request to make it so, I'll keep this issue open to receive more feedback. Maybe an option could be nice to make it customizable.

Unnecessary logic on a neutral action. Allow users to override this logic with extra parameters, at the very least.

Any news about this ? I am using 7.1.3 and still having this problem.

any updates on this? the component is very good and has a nice api but this logic is killing it for our project.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

cyberrranger picture cyberrranger  路  3Comments

jisqaqov picture jisqaqov  路  3Comments

gatapia picture gatapia  路  3Comments

pchristou picture pchristou  路  3Comments

philly-vanilly picture philly-vanilly  路  3Comments