Primeng: Add FontAwesome 5 support

Created on 5 Feb 2018  路  4Comments  路  Source: primefaces/primeng

I'm submitting a ...

[x] feature request

Current behavior
FontAwesome 5 breaks FontAwesome 4 because the syntax has changed. For example, before you would do fa fa-circle-o for an outline circle icon, in the new version they've changed the whole prefix system. Now you would do far fa-circle for an outline circle and fas fa-circle for a solid circle. They've also removed aliases so now every icon only has one class name.

FontAwesome also provides a js shim file to add backwards compatibility quick and easy. I don't know if that will be useful here, you may have to do a full, proper upgrade using find and replace to update all the obsolete FA class names.

See their guide on how to use FA5 when upgrading from FA4:
https://fontawesome.com/how-to-use/upgrading-from-4

Please tell us about your environment:

  • Angular version:
    5.2.3

  • PrimeNG version:
    5.2.0

Most helpful comment

Font Awesome now provide a component for their icons:
https://fontawesome.com/how-to-use/on-the-web/using-with/angular
It's hard to use it in buttons by exemple...

All 4 comments

5098 #5060 #4488 seem to be related, but not exactly duplicate issues.

I really hope PrimeNG will add support for FA5 SVG core. This way we can fully switchover to minified SVGs instead of web fonts. Moreover, we could reduce bundle size by only importing the icon svgs that we need.

Font Awesome now provide a component for their icons:
https://fontawesome.com/how-to-use/on-the-web/using-with/angular
It's hard to use it in buttons by exemple...

Was this page helpful?
0 / 5 - 0 ratings

Related issues

lilling picture lilling  路  3Comments

gatapia picture gatapia  路  3Comments

philly-vanilly picture philly-vanilly  路  3Comments

mitosandov picture mitosandov  路  3Comments

watalberto picture watalberto  路  3Comments