Prettier-vscode: Regression: Semicolons setting is ignored

[freed00m]

You must complete all steps in this checklist or the issue will be automatically closed.

• [x] Write a summary of your issue
• [x] Include a link to a github repo that can be used to reproduce the issue or exact reproduction steps.
• [x] Provide the expected result
• [x] Provide the actual result
• [x] Include extension, os, and vs code information
• [x] Include Prettier extension log

Summary

Regresion from version 3.7.0, when I downgrade plugin, the option is honored and working as expected

Github Repository to Reproduce Issue

No need, open any TypeScript file and observe the inserion of semicolons.

also I use "editor.formatOnSave": true, but seems unrelated

Steps To Reproduce:

1. set "prettier.semi": false, in ~/.config/Code - OSS/User/settings.json
2. Start vscode and open any Typescript file,
3. remove or make sure you don't terminate lines with semicolons

Expected result

Honor the "prettier.semi": false, config option and do not add semicolons

Actual result

The prettier see the semi config option being false but ignores it and put semicolons as if I set it to true

Additional information

This is a regression from 3.7.0 version of this plugin

It is similar issue as #1085

VS Code Version: 1.40.0-3

Prettier Extension Version: 3.8.0

OS and version: 5.3.12-1-MANJARO && Windows 10 1803

Prettier Log Output

[INFO - 3:44:39 PM] Formatting /home/frdm/src/webserver-ui/frontend/src/app/app.module.ts.
[INFO - 3:44:39 PM] Using bundled version of prettier.
[INFO - 3:44:39 PM] Resolved ignore file to /home/frdm/src/webserver-ui/frontend/.prettierignore.
[INFO - 3:44:39 PM] File Info:
{
  "ignored": false,
  "inferredParser": "typescript"
}
[INFO - 3:44:39 PM] Prettier Options:
{
  "arrowParens": "avoid",
  "bracketSpacing": true,
  "endOfLine": "auto",
  "htmlWhitespaceSensitivity": "css",
  "insertPragma": false,
  "jsxBracketSameLine": false,
  "jsxSingleQuote": false,
  "printWidth": 80,
  "proseWrap": "preserve",
  "quoteProps": "as-needed",
  "requirePragma": false,
  "semi": false,
  "singleQuote": true,
  "tabWidth": 2,
  "trailingComma": "none",
  "useTabs": false,
  "vueIndentScriptAndStyle": false,
  "filepath": "/home/frdm/src/webserver-ui/frontend/src/app/app.module.ts",
  "parser": "typescript"
}
[INFO - 3:44:40 PM] Formatting completed in 104.164077ms.

[close-issue-app[bot]]

This issue is closed because it does not match our issue template or include all the required information. Please read and follow the instructions and reopen.

[freed00m]

Ah it is by design

The #1079 explains that.

.editorconfig file existed and all prettier options in settings.json were ignored. BY DESIGN

[ntotten]

Sorry, the bot closed this issue by mistake. I had a typo in the config of the bot. But yes, this is by design.

[freed00m]

@ntotten no problem, but could you give it another thought? removing trailing semicolon is not possible with editorconfig file :/ https://github.com/editorconfig/editorconfig/issues/331

You even said it's good idea to have .editorconfig but what I can do now? to remove semicolons?

[ntotten]

@freed00m add a prettier config file to the project.

[github-actions[bot]]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.