Prettier-vscode: Weird auto-formatting of code upon paste

[klippx]

Description

In JS files this extension will sometimes mess up indentation upon pasting. The circumstances under which this seems to happen is when having "editor.formatOnPaste": true enabled (something that Atom Keymap adds to your config automatically).

With prettier extension _disabled_:

This is when having prettier disabled. I start out by marking the text and pressing CMD+C, place the cursor where I want to paste, and CMD+V. Everything pastes as one would expect.

With prettier extension _enabled_ and _including_ trailing comma

This is after enabling prettier. Again, I mark the text, copy it, paste it. Split second after pasting prettier has formatted everything in a horrific manner.

With prettier extension _enabled_ an _excluding_ trailing comma

I then found out that if I do not mark the last comma in the selection I want to copy+paste, it works even with prettier enabled.

Snippet:

module.exports = ({ config }) => {
  return [
    {
      key: 'some value',
      fn: async (req, res) => {
        return 'some value'
      },
    },
  ]
}

My config:

{
  "workbench.colorTheme": "Oceanic Next Italic",
  "window.nativeTabs": true,
  "editor": {
    "formatOnSave": true,
    "fontFamily": "Fira Code",
    "fontSize": "16",
    "fontLigatures": true,
    "tabSize": 2,
    "tabCompletion": true,
  },
  "prettier": {
    "singleQuote": true,
    "semi": false,
    "trailingComma": "es5",
    "printWidth": 100
  },
  // added by atom keymap
  "atomKeymap.promptV3Features": true,
  "editor.multiCursorModifier": "ctrlCmd",
  "editor.formatOnPaste": true
  // end atom keymap
}

[CiGit]

Yep same thing happens by calling the range formatter (Format selection). FormatOnPaste calls the range formatter.

It messes the output if the trailing-comma is selected/pasted.
It throws if it is not selected/pasted.

[CodingDive]

I experience the same, also added a gif inside another issue because I first thought VS code was causing the behaviour. https://github.com/Microsoft/vscode/issues/33522

[CiGit]

This should be fixed in prettier 1.8 (version we are now bundling)

[SYGINT]

I'm still experiencing this issue with the latest extension 1.5.0

[gabrielmicko]

Me too in VSCode!

[gabrielmicko]

I think "editor.formatOnPaste": false, fixed my issue.

[Gwillison415]

"editor.formatOnPaste": false did not fix my issue.. the way it imports and formats is whack, but undo fixes it.

[faiz021]

This worked for me: Go to VS Code Settings -> from the User Settings tab -> Text Editor -> Formatting -> Untick the first option 'Format On Paste'

[zenoven]

same issue, very annoying

[eddiejaoude]

Thanks @faiz021 , that worked for me

[jasonpberry]

This was driving me insane. Found the config and turned it off and I'm happy again :) Of course, now I find the fix here :)

[Drumstix42]

This is still an outstanding issue on 1.9.0.
Disabling "Format On Paste" is not a good solution, but merely a workaround.

[ackvf]

My "Format on Paste" is disabled since long time ago, but I still experience this!

[Siregar]

Still happening... this is so annoying.
VS Code v1.36.1

[menteshynov]

I am setup "editor.formatOnPaste": true, and this is fix my issue. I am use Prettier + ESLint + Airbnb Style Guide

VS Code v1.36.1

[github-actions[bot]]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.