Prettier-vscode: JSX files don't have the Format Document option

[jshamley]

Thanks for an awesome plugin. This is working great for .js, .html and .json files but I do not see the option to format a .jsx document. I installed the extension through the marketplace and it is currently at version 0.11.0

I have this JSX extension installed with version 0.0.1 https://marketplace.visualstudio.com/items?itemName=TwentyChung.jsx

[esbenp]

What does it say in your status bar when you have a JSX file open? In the bottom of the window

[jshamley]

it says JSX instead of JavaScript React.

[esbenp]

Okay, so I added an activation event now that activates the plugin when the language is jsx. That should work. Give it a go and let me know :-)

[jshamley]

Hmmm, still nothing. I updated and even restarted my machine to see if it would work.

I notice that it shows the Format Document option in HTML, even though you don't have it listed in your activationEvents array.

[CiGit]

@esbenp only the activation event is not enough. You need to also register the formatter here

I've no time to take a deep look at the linked extension, but just with the readme, i don't see it's usefulness anymore. JSX is well supported out of the box by code, so I don't see the point in adding a new language.

[CiGit]

I don't blame the extension. But it seems to be an old one developed during code's first days.
It has a lot of downloads tho

[CiGit]

I forgot to respond to the initial post.
@jshamley This extension doesn't run on html json files. this may be the formatter provided by code or an other one you installed for these document types.

[CiGit]

Can we revert or finish the fix ?

[esbenp]

What do you think? @CiGit #82

[CiGit]

I've commented on the PR.

@jshamley Do you still use jsx extension ?

[jshamley]

For this project we moved away from using Prettier to using a custom ES-Lint configuration. I have also changed away from that JSX extension. The javascriptreact syntax does a fine job with the code anyways.

[CiGit]

Now it should work :)

[robertmills1985]

works good for me now

[github-actions[bot]]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.