Prettier-eslint: Support eslint 5

Created on 28 Sep 2018  路  5Comments  路  Source: prettier/prettier-eslint

ESlint 5 have released for a period of time, would you considering add support of it?

Versions:

  • prettier-eslint version:
  • node version:
  • npm (or yarn) version:

Have you followed the debugging tips?

Yes || No

Relevant code or config


What I did:

What happened:

Reproduction repository:

Problem description:

Suggested solution:

no-issue-activity

Most helpful comment

I second the thought that prettier-eslint should have listed prettier and eslint as peerDependencies. This, especially since prettier-eslint does not import these dependencies anywhere in its code.

All 5 comments

I second the thought that prettier-eslint should have listed prettier and eslint as peerDependencies. This, especially since prettier-eslint does not import these dependencies anywhere in its code.

Will accept a pr for this

@pastelsky it does import those dependecies if it can't find prettier or eslint in your project, thats why they are dependencies and not peer dependencies

I'm looking into this today.

Stale issue

Was this page helpful?
0 / 5 - 0 ratings

Related issues

cellog picture cellog  路  3Comments

anback picture anback  路  5Comments

chrisbobbe picture chrisbobbe  路  8Comments

Dimomir picture Dimomir  路  5Comments

grit96 picture grit96  路  3Comments