Prettier-atom: Editor crashing on save

Created on 13 Mar 2018 · 21Comments · Source: prettier/prettier-atom

Hi,
I love this package but I have an annoying issue with "big files", ie more than 200 lines
Everytime I update something and I save the file --> atom is crashing.

Sometimes it's only freezing but I need to wait more than 30seconds [ too much ].
Most of the time Atom is when I'm commented something.

Thanks,

Source

majdi

Most helpful comment

I just install locally prettier@^1.11.1 and it works well. Thanks @olsonpm!
Hope you'll find the origin of this weird bug 🤓

majdi on 14 Mar 2018

🎉2

All 21 comments

Hi there!

Could you provide an example of a file that causes Atom to crash as well as your current package list?

$ apm list --installed --bare

SavePointSam on 13 Mar 2018

Sure,

This is my package list:

I can't provide a full example of my code but you can see the structure here

majdi on 13 Mar 2018

are you able to reproduce with "a big file" and post the contents of that? We're mainly looking for ways to reproduce and understand your issue. I've used the prettier plugin on many files larger than 200 lines, and I doubt it's a hardware issue as 200 is just not that much.

olsonpm on 13 Mar 2018

Hi @olsonpm,
I reproduce the issue, it's not about the size of the file, I think it's something else;
You can find here another gist with less than 120 lines.

The crash happen when I comment any import line on the top of the file and I save the file.
I also don't think it's an hardware issue.

Thanks :)

majdi on 14 Mar 2018

haha what a weird bug. I'm able to reproduce. I'll let you know what I find and thanks for taking the time to get reproduceable steps!

olsonpm on 14 Mar 2018

You're welcome :-D
I'll try to find how to fix-it too.

majdi on 14 Mar 2018

👍1

wow this was frustrating. I don't know what's going on but updating the prettier version fixes it.

@robwise @SavePointSam, unless either of you want to take a deeper look, does it sound okay to update the bundled prettier version and advise users to update their prettier version locally if they come across this bug?

Some debugging notes for reference:

if I run the text through prettier cli @ 1.10.2 (version bundled with plugin) the delay doesn't appear. I didn't try other editors
the delay seems to correlate with the complexity of the jsx. Removing chunks of the jsx reduces the time down to a reasonable amount. Modifying any code at the top level i.e. not code within the class declaration produces the delay
the delay happens here in prettier
that file was only slightly modified between 1.10.2 -> 1.11.1. I didn't dig into the changes to understand it further.

// src/main/ast-to-doc.js

 const comments = require("./comments");
 const FastPath = require("../common/fast-path");
 const multiparser = require("./multiparser");
-const util = require("../common/util");

 const doc = require("../doc");
 const docBuilders = doc.builders;
@@ -75,7 +74,10 @@ function genericPrint(path, options, printPath, args) {

   // Escape hatch
   if (printer.hasPrettierIgnore && printer.hasPrettierIgnore(path)) {
-    return options.originalText.slice(util.locStart(node), util.locEnd(node));
+    return options.originalText.slice(
+      options.locStart(node),
+      options.locEnd(node)
+    );
   }

   if (node) {

the release notes also didn't give any clues

olsonpm on 14 Mar 2018

@majdi - a workaround for now would be to install the latest prettier local to your project. Then the plugin will take that version instead of:

one found in your node_modules if prettier was installed as a direct or indirect dependency
if none exist in node_modules, it takes the prettier bundled in this plugin (1.10.2)

olsonpm on 14 Mar 2018

🎉1

Have you tried passing in a different AST parser when calling the CLI from our end? We may be providing an incorrect parser for the file type. Can you look into that as a potential solution, @olsonpm?

I personally don't mind updating our bundled Prettier, but we should probably explore other potential solutions to figure out if we really are the problem first, even more so because there is no mention in the release notes about this problem. Did you look in the Prettier issues for something related?

SavePointSam on 14 Mar 2018

i just pasted his code into a brand new js file so unless i've always been passing an incorrect parser i doubt that's the issue. I also didn't check this on a clean install, so it's possible package conflicts are at play. However given the delay happens at that one recursive call and prettier fails to throw an error, I think there's something else is going on.

Honestly I've sunk as much time into this issue as I care to as well. This was making my atom crash at times and so the debugging experience wasn't great. I'm not going to debug further.

olsonpm on 14 Mar 2018

I'll bump now and we can see if it solves the issue, it never hurts to bump it anyway.

robwise on 14 Mar 2018

👍1

it solved the issue for me locally inside atom --dev with prettier atom dev linked. You're right OP should verify the fix though :)

thanks robwise

olsonpm on 14 Mar 2018

I just install locally prettier@^1.11.1 and it works well. Thanks @olsonpm!
Hope you'll find the origin of this weird bug 🤓

majdi on 14 Mar 2018

🎉2

Okay bumped to prettier 1.11.1 in prettier-atom 0.52.0

robwise on 14 Mar 2018

I've given up actually haha. I've got some problems that are more interesting atm and bumping a version is a good'nuff stopping point for me.

@majdi If you have a moment please try the new version of prettier-atom to make sure it solves your problem. If it does then go ahead and close the issue.

olsonpm on 14 Mar 2018

Perfect @olsonpm it works in both cases. Thanks guy 👍

majdi on 15 Mar 2018

👍1

Hey, this still happens for me on the latest version of the plugin

joarwilk on 19 Mar 2018

Did you have the same issue than me? I didn't have any problem still the update.

majdi on 19 Mar 2018

@joarwilk, see what version of prettier is installed in your node_modules. Even if you don't install prettier as a dependency, if one is installed indirectly (via another dependency) then the plugin picks that one up.

olsonpm on 19 Mar 2018

Went away after a fresh computer restart. Probably some spooky cache still giving me the previous version after updating. Works just fine now!

joarwilk on 30 Mar 2018

👍1

FYI: Still crashes on large Copy&Paste and save in .vue File.

If I use only half the data, it works fine.

Atom: 1.44.0 x64 (OSX)
Prettier-Atom: 0.58.2