Presto: show create table is not checked with accessControl

Created on 10 Sep 2019  路  4Comments  路  Source: prestosql/presto

show columns from ;
and show create table ;
are both showing a common base data related to columns (column name and type)

but when executing show create table , accessControl.checkCanShowColumnsMetadata is not called
as a result, a user is granted access to information that should have been filtered by the same permissions defined on columns

bug

Most helpful comment

@kokosing I have a one-line fix for that fix it is just I need to sort out CLA first

All 4 comments

@kokosing I have a one-line fix for that fix it is just I need to sort out CLA first

I have a one-line fix for that

Awesome! That was really quick. Does it work for both cases? Do you have tests for that?

should be covered, I will need to add more tests though

I'm closing this issue because the related PR was already merged.

Was this page helpful?
0 / 5 - 0 ratings