Presto: Support FNV hash functions

Created on 20 Mar 2019  路  13Comments  路  Source: prestodb/presto

https://en.wikipedia.org/wiki/Fowler%E2%80%93Noll%E2%80%93Vo_hash_function

There are different flavors of this hash function. We'd like to introduce
bigint fnv64(binary)
bigint fnv32(binary)

available-to-pickup beginner-task

All 13 comments

Similar to spooky hash (https://prestodb.github.io/docs/current/functions/binary.html#spooky_hash_v2_32), we should just have fnv32 and fnv64 .

@rongrong I would like to pick up this task. Would you recommend adding this hash function to Slice library and then import in scalar/VarbinaryFunctions.java? Or should i just directly add the function in scalar/VarbinaryFunctions.java?

It makes sense to introduce this to airlift Slice to me. @electrum What do you think?

@codope Are you working on adding this to airlift? If that's taking too long, let's just add this to Presto directly.

@rongrong I have not started yet but I think it'd be better to add this to Airlift. I'll work on it next week. Let me know if it's urgent then I'll simply add it to Presto first.

@codope Have you been able to make some progress with these functions? I was thinking of adding them directly to Presto.

@gastonar Yes, it is in progress.

@codope could you please ping airlift to get this merged? If they are not responsive feel free to directly write the function in Presto. Thanks!

@rongrong I have pinged the team. Let's wait till this week. If that diff is not merged, I'll add the function to Presto directly.

Update: Waiting for the latest version of Slice to be released on maven central.

@codope are you still working on this?

@rongrong sorry, the work is paused on this. I have asked for the latest version of slice on maven as per this comment. Let's wait one more week. If still no progress, I will add the function directly in Presto.

@codope It's been a while, do you want to finish this off?

Was this page helpful?
0 / 5 - 0 ratings

Related issues

aminalaee picture aminalaee  路  3Comments

sopel39 picture sopel39  路  3Comments

tesseract2048 picture tesseract2048  路  3Comments

dterror-zz picture dterror-zz  路  4Comments

tomz picture tomz  路  3Comments