Prestashop: Inconsistent schema.org usage of http:// and https://

Created on 15 Dec 2020  路  6Comments  路  Source: PrestaShop/PrestaShop

Describe the bug

In pr #22417 review @PululuK noticed the usage of http:// in shema.org itemtype definition.

Both are fine but it is nice to be consistent: https://schema.org/docs/faq.html#19

Expected behavior

All schema.org itemtypes consistently use https://

Steps to Reproduce

Steps to reproduce the behavior:

git grep schema.org | grep 'http:'
git grep schema.org | grep 'https:'

Additional information

  • PrestaShop version: N/A
  • PHP version: N/A
1.7.7.0 CO Fixed Improvement PR available SEO & URLs

Most helpful comment

Hi @tswfi, thanks for your contribution! As far as I know, there is no public documentation to introduce to the different labels used on this repository but what we could do is at least add and/or improve their descriptions here. :-)

All 6 comments

Hello @tswfi

Thanks for your issue and PR :smile:

Ping @PrestaShop/prestashop-core-developers do you agree with @PululuK about replacing http:// by https://?

Yes it's a good idea

@PierreRambaud should the label be "pr available" (or whatever it was) as #22419 fixes this.

Actually is the labeling documented somewhere? might help new people (I know it would help me) to know what all of these labels mean to you :)

I don't know if the label is needed since GitHhub provides a way to find related PR:
image

But for labels, you should see with @PrestaShop/product-team :sweat_smile:

Hi @tswfi, thanks for your contribution! As far as I know, there is no public documentation to introduce to the different labels used on this repository but what we could do is at least add and/or improve their descriptions here. :-)

Was this page helpful?
0 / 5 - 0 ratings