Prestashop: Remove GridHTML dependency

Created on 10 Dec 2020  路  5Comments  路  Source: PrestaShop/PrestaShop

Is your feature request related to a problem?

GridHTML is a dependency which should be a library rather than a module.
The hook for using this module is displayAdminStatsGridEngine.
Actually, it is not used : http://modok.prestashop.com/api/hooks?name=displayAdminStatsGridEngine.

Describe the solution you'd like

Remove it from dependencies

CO Improvement PM 鉁旓笍 To Do

Most helpful comment

As we discussed during a meeting about modules GridHtml is not necessary to display tables in the BO, we already provide a modern Grid system. But it can be used as a dependency like the NVD3 Charts. To be cristal clear, don't use them as a module, but as a composer dependency.

All 5 comments

Hello @Progi1984

Thanks for the suggestion, the Product Team and the Developer Team will take a look :sweat_smile:
Please stay tuned !

Ping @PrestaShop/product-team @PrestaShop/prestashop-core-developers , do you approve to remove this dependency?

Hi @Progi1984 and @hibatallahAouadni, thanks for your improvement idea. Along with the NVD3 Charts module (graphnvd3 as technical name), GridHTML should be integrated into the core since they are necessary to display tables and charts in the BO. It is non-sense to keep them as options.

As we discussed during a meeting about modules GridHtml is not necessary to display tables in the BO, we already provide a modern Grid system. But it can be used as a dependency like the NVD3 Charts. To be cristal clear, don't use them as a module, but as a composer dependency.

So, the final decision is to not use the GridHTML as a module, but as a composer dependency. Is that so?

We have to transform the module into a composer dependency yes :+1:

Was this page helpful?
0 / 5 - 0 ratings

Related issues

zuk3975 picture zuk3975  路  3Comments

centoasa picture centoasa  路  3Comments

khouloudbelguith picture khouloudbelguith  路  3Comments

PrestaShark picture PrestaShark  路  3Comments

esistgut picture esistgut  路  3Comments