Prestashop: Fix bug with condition display packaging price

[dariusakafest]

Describe the bug

The "Product::getNoPackPrice" method returns an incorrect value for comparison; a string of the form "$ 10.99" is returned, which leads to an incorrect comparison

Steps to Reproduce

Steps to reproduce the behavior:

Create pack product, go on front page and see

Additional information

• PrestaShop version: 1.7.4
• PHP version: 7.2

---

Steps to reproduce on PS1770 & develop:

1. BO > Catalog > Products > Create pack contains 2 or 3 products
2. set its price less than the really sum of all products prices (ex: P1: 19.12 + P2: 18.90 + P3: 12.90 = 50.92 > Pack_price: 40)
3. FO > Pack page: we only see the price of the pack we don't see the text "Instead of 50.92"

1. BO > International > Localization > Currencies > edit the current currency (ex: euro)
2. Click on edit button (see screenshot below)

1. A pop up is open, we need to change the displayed position of the currency
2. Choose the option in the green square (see screen shot below)

1. Click on Apply, the popup is closed
2. Click on Save
3. FO > Pack page > now we see the pack's price and the text "Instead of 50.92" below

Steps to reproduce on 1.7.6.8 and 1.7.4.1:

1. BO > Catalog > Products > Create pack contains 2 or 3 products
2. set its price less than the really sum of all products prices (ex: P1: 19.12 + P2: 18.90 + P3: 12.90 = 50.92 > Pack_price: 40)
3. FO > Pack page: we only see the price of the pack we don't see the text "Instead of 50.92"
4. Change the language to French, cause in the French language currency change its position
5. The text "Instead of 50.92" will be displayed (of course with the french language)

ScreenRecord:

PS1.7.4.1: https://drive.google.com/file/d/18Bk-l-4zWjuAb9__Ts-UWHemh6LlP4d8/view
PS1.7.7.0: https://drive.google.com/file/d/11Vqwi0fIaqkadj5d4Re62KVlWwxCH9T8/view

[hibatallahAouadni]

Hi @dariusakafest

I didn't see any error (see the screen shot below)

Could you please provide steps to reproduce the issue more clearly.

PS: don't mind the price of the pack, it's me who want it to be 50 euro without tax.

Thanks!

[dariusakafest]

@hibatallahAouadni Hi!
Now I don't remember all the details of how I got the error, but please see this code
https://prnt.sc/vgp2m8
Do you think it is correct to compare the float value for example "100" with the string "$100"
https://prnt.sc/vgp3gf
I think that the comparison should be done with the types suitable for this.

[SimonGrn]

We need a specific list of steps to reproduce. Please provide a clear scenario with all the steps.

[dariusakafest]

@SimonGrn set product price 50.2

$this->context->smarty->assign('displayPackPrice', ($pack_items && $productPrice < $this->product->getNoPackPrice()) ? true : false);

displayPackPrice will become false

[dariusakafest]

@SimonGrn.
You have the sum of the goods in the pack: 50.92! Product price 50 !
https://prnt.sc/vhgqoj
You should see here on the page: "Instead of 50.92". And he is not there !

When product bundle price < sum pack items price you must see here:

[dariusakafest]

@SimonGrn And all why because you compared like this:
50 < $50,92, $50,92 converted in php to => 50.00

[hibatallahAouadni]

@dariusakafest

PS: don't mind the price of the pack, it's me who want it to be 50 euro without tax.

I already said it that it's me who want it to be 50(tax exclu)
Here's the price edited:

Thanks!

[dariusakafest]

@SimonGrn Ok.

1. Set the price product 40 now, Set the price display mode to 40$, no $40. After see here:
   https://prnt.sc/vhhz2g
2. Change the display mode of the price from 40$ to $40
   Again see here https://prnt.sc/vhhz2g

You must see "Instead of 40$" In the second case, you will not see it

[hibatallahAouadni]

Hello @dariusakafest

Thanks for clarifying and your patience. i managed to reproduce your issue with PS1.7.4.1, PS1.7.6.8, PS1.7.7.0-rc.1+build.4 and develop.

Steps to reproduce on PS1770 & develop:

1. BO > Catalog > Products > Create pack contains 2 or 3 products
2. set its price less than the really sum of all products prices (ex: P1: 19.12 + P2: 18.90 + P3: 12.90 = 50.92 > Pack_price: 40)
3. FO > Pack page: we only see the price of the pack we don't see the text "Instead of 50.92"

1. BO > International > Localization > Currencies > edit the current currency (ex: euro)
2. Click on edit button (see screenshot below)

1. A pop up is open, we need to change the displayed position of the currency
2. Choose the option in the green square (see screen shot below)

1. Click on Apply, the popup is closed
2. Click on Save
3. FO > Pack page > now we see the pack's price and the text "Instead of 50.92" below

Steps to reproduce on 1.7.6.8 and 1.7.4.1:

1. BO > Catalog > Products > Create pack contains 2 or 3 products
2. set its price less than the really sum of all products prices (ex: P1: 19.12 + P2: 18.90 + P3: 12.90 = 50.92 > Pack_price: 40)
3. FO > Pack page: we only see the price of the pack we don't see the text "Instead of 50.92"
4. Change the language to French, cause in the French language currency change its position
5. The text "Instead of 50.92" will be displayed (of course with the french language)

ScreenRecord:

PS1.7.4.1: https://drive.google.com/file/d/18Bk-l-4zWjuAb9__Ts-UWHemh6LlP4d8/view
PS1.7.7.0: https://drive.google.com/file/d/11Vqwi0fIaqkadj5d4Re62KVlWwxCH9T8/view

I’ll add this to the debug backlog so that it’s fixed.

Thank you!

[khouloudbelguith]

Hi @PrestaShop/qa-functional

This issue should be fixed with this PR: #21732

Thanks!

[marionf]

Hi @RomainBocheux

As this issue seems to be a duplicate of #21034, could you check if this issue is well fixed on develop following the merge of #21732 ?

Thank you :)

[RomainBocheux]

Hi @marionf,

The PR #21732 fix this issue

Thank you