Prestashop: Email : Lots of translations don't work

[okom3pom]

Describe the bug

Lots of translations don't work, the Translation file ( EmailsBody.fr-FR.xlf ) don't match with twig file.

Steps to Reproduce

Steps to reproduce the behavior:

1. Install a shop with French language
2. Make an order
3. Check the mails
4. See error

For exemple If i change in EmailsBody.fr-FR.xlf

<source><![CDATA[Review this credit slip and download your invoice on our shop, go to the <a href="{history_url}" target="_blank">Credit slips</a> section of your customer account.]]></source>

By

<source><![CDATA[Review this credit slip and download your invoice on our shop, go to the <a href="{history_url}" target="_blank">%credit_slips_label%</a> section of your customer account.]]></source>

%credit_slips_label% != Credit slips

And i generate email template, translation work

Screenshots

If applicable, add screenshots or screen recordings to help explain your problem.

Additional information

• PrestaShop version: 1.7.7.0 2020-10-5
• PHP version: N/A

[prestashop-issue-bot[bot]]

Thanks for opening this issue! We will help you to keep its state consistent

[khouloudbelguith]

Hi @okom3pom,

Thanks for your report.
I manage to reproduce the issue with PS1.7.7.0rc1.

I tried to translate this expression from BO > International > Translation page => NOK

I tried to translate this expression from BO > Design > Email theme page => NOK

With PS1.7.6.8 => ok

It is a regression.
I’ll add this to the debug roadmap.
Thanks!

[atomiix]

@okom3pom @khouloudbelguith It looks like this bug will be fixed as soon as the translation catalogue is pushed on crowdin.

[okom3pom]

@atomiix

I asked for an access on crowdin i wait :)

Here it's https://github.com/PrestaShop/TranslationFiles/tree/master/1.7/translations/1.7.7/fr-FR not a reflect of crowdin ?

[okom3pom]

And before pushed it's possible to see : https://github.com/PrestaShop/PrestaShop/pull/21273 ?

[jolelievre]

Your PR is a nice improvement, however it won't be integrated in 177 because it doesn't just change the email template and is a new feature. So nothing to worry regarding the 177 catalog update which should be performed tomorrow

[marionf]

Verify if it work after the catalog update tomorrow

[okom3pom]

I made a test today it's the same.

[SimonGrn]

@okom3pom the catalog wasn't pushed. Don't worry, we're on it :)

[jolelievre]

Hi @okom3pom,

I just pushed the new translation towards Crowdin our Translation platform. So the translation archives for
PrestaShop should be updated tomorrow. The workflow updates them once a day I believe around 7AM.

I'll check tomorrow that everything updated correctly.

[okom3pom]

Yes i received an email

[jolelievre]

Hi @okom3pom,

I tested a few things so it turns out the catalog for french is not completely up to date yet, the new wordings
still need to be translated in Crowdin and only then will they be integrated into the TranslationFiles repo which
is used to generate the languages archives.

However I tested the Translation of Emails text again in the BackOffice and I think it works now, I can see some
wordings that are not translated yet including the one you are referring to:

Review this credit slip and download your invoice on our shop, go to the <a href="{history_url}" target="_blank">%credit_slips_label%</a> section of your customer account.

So it is now accessible because the default catalog has been updated with the missing wording recently
in this PR https://github.com/PrestaShop/PrestaShop/pull/21179 and they are now accessible in the
Translation interface. I can only guess that you tried a version of the 177 branch before this PR was merged.

I believe I made the same test as @khouloudbelguith but it worked fine for me, I edited the translations by
accessing it via Design > Email theme And then I selected french in the Translate emails before clicking
on the button. This redirects me to the translation manager to edit workspace EmailsBody

Once it's saved I checked the result using the preview system for Email theme:

I just modified the locale manually /improve/design/mail_theme/preview/fr-FR/modern/credit_slip.html because
it uses the default language (en in my case, but if you selected fr as your profile language it will display it
automatically).

And finally, to be sure, I regenerated the emails without selecting a theme (Core option) and forcing Overwrite which
updates the static mail template stored in mails/fr/credit_slip.html
If you have a shop theme installed you should regenerate the emails selecting it in the option so that static templates
are generated in the appropriate theme folder (if present) like theme/your_theme/mails for example.

Can you please retry with the latest 1.7.7.x branch and confirm it works ok?

[okom3pom]

Hello,

I always use the last nightly.

It's ok for me now.

[jolelievre]

Hi @okom3pom I just tested to modify this wording in the BO and it works fine (the wording itself is not translated yet, but I'm sure the crowdin community is working on it 🙂), so I'm gonna close this issue.

Thanks for your report