Prestashop: Remove cache on module ps_sharebuttons

[kpodemski]

Please remove cache from this module. This is useless:

https://github.com/PrestaShop/ps_sharebuttons/blob/master/ps_sharebuttons.php#L145

There is nothing to cache, and because of complexity of cache key we have thousands more files of cache worth nothing...

[Progi1984]

@kpodemski Please create issue on the repo "PrestaShop/PrestaShop".

@PrestaShop/prestashop-product-team Can we close issues on this repository ?

[sam-pires]

Hi @Progi1984,
Once the 2 issues in the repo are transferred to /recreated in the PrestaShop/PrestaShop repo, you can close issues.

[prestashop-issue-bot[bot]]

Thanks for opening this issue! We will help you to keep its state consistent

[florine2623]

Hi @PrestaShop/prestashop-core-developers ,

Could you take a look at @kpodemski 's request ?
Is it relevant ?

Thanks!

[kpodemski]

@sam-pires all issues, even those related to modules should be created in main repo?

[Progi1984]

@kpodemski Affirmative

[sam-pires]

@kpodemski, yes it is better.
We still have some issues related to modules, in the modules' repos. But to be able to manage the issues in the development boards/kanban, they have to be on the main repo.

So we are progressively disabling issues submission on all modules repos and transfering existing issues to the main repo. As @Progi1984 did this morning with this one 🙂

Instead of having the issues in a module's repo, we use the yellow labels to indicate which module the issue is about

[kpodemski]

@sam-pires good choice, i remember my frustration with issues (and PRs) open in modules for years ;)

[kpodemski]

@Progi1984 for the record, few weeks ago i cleaned cache folder from over 2GB of cache files for sharebuttons module :P

in getWidgetVariables we're not doing anything "heavy", Configuration is cached by default etc.

[matks]

Will be fixed by https://github.com/PrestaShop/ps_sharebuttons/pull/40

[Progi1984]

Fixed by PrestaShop/ps_sharebuttons#40