Prestashop: Creating a once deleted currency causes duplicate rows in database

[khouloudbelguith]

Describe the bug
When a currency is added in PrestaShop it is impossible to add it a second time, thus it prevents having duplicate
However, if you delete a currency and then add it again a new row is inserted and the former one is still present with its deleted column set to 1 (soft delete)
This means the database has duplicated rows, and that different orders with the same currency do not use the same one in database
To Reproduce
Steps to reproduce the behavior:

1. Go to Internationalisation > Localization > Currencies
2. Add a new currency (for example USD)
3. Go back to the currencies list and delete the newly created currency
4. Download the "added and deleted" curreny localization pack, for example, United Stets pack
5. A second row in the database is created

Screenshots

Additional information
PrestaShop version: 1.7, 1.7.7.x
PHP version: 7.1

[khouloudbelguith]

Ping @matthieu-rolland
Related to https://github.com/PrestaShop/PrestaShop/pull/16287

[colinegin]

Is this a regression ? Should it be fixed for 177 ?

[khouloudbelguith]

Hi @colinegin,

No, it is not a regression.
Same issue with PS1.7.5.2 & PS1.7.6.3

In fact, this issue is not totally fixed.

Thanks!

[jolelievre]

@khouloudbelguith I think this one is not only related but seems like a duplicate of https://github.com/PrestaShop/PrestaShop/issues/15934
Which has been fixed by this PR in 1.7.7 https://github.com/PrestaShop/PrestaShop/pull/16287/files

[khouloudbelguith]

Hi @jolelievre,

No, this issue is not fixed in the PS1.7.7.
I can reproduce the issue with 177x branch
https://drive.google.com/file/d/132ouko0vHbDeP1ro0KL902C0-DRS-86X/view?usp=sharing
Following these steps

1. Go to Internationalisation > Localization > Currencies
2. Add a new currency (for example USD)
3. Go back to the currencies list and delete the newly created currency
4. Download the "added and deleted" curreny localization pack, for example, United Stets pack
5. A second row in the database is created

Thanks!

[jolelievre]

Oh my bad! I didn't understand it was added via the localization pack
Thank you @khouloudbelguith