Prestashop: displayBanner hook is missing

[jf-viguier]

Describe the bug
displayBanner hook is missing in database and in hook.xml

Additional information
PrestaShop version: 1.7.*
PHP version: 7.2

[khouloudbelguith]

Hi @jf-viguier,

Thanks for your report.
I have the same issue with PS1.7.6.3 & PS1.7.5.2

With PS1.6.1.24, it is not missing

I’ll add this to the debug roadmap.

Thanks!

[jf-viguier]

Thanks @khouloudbelguith can you paste here the hook part in hooks.xml of PS1.6.1.24 ?

[khouloudbelguith]

@jf-viguier,

https://github.com/PrestaShop/PrestaShop/blob/1.6.1.24/install-dev/data/xml/hook.xml

Thanks!

[jf-viguier]

The hook is not there, I guess it's a module that have created the hook in database with registerHook

[PierreRambaud]

As I said in your pull reuqest, the hook should be created by the module and not the Core :thinking:

[khouloudbelguith]

@jf-viguier, it is the Banner block module.

@PierreRambaud said, if we install a module that create the displayBanner hook, it will be displayed.

Thanks!

[jf-viguier]

@PierreRambaud I don't understand, the hook is launched in header.tpl in the core classic theme. We have modules that uses that hook : it has to be in the database and hooks.xml.

[jf-viguier]

As I said in your pull reuqest, the hook should be created by the module and not the Core 🤔

@PierreRambaud I disagree. The hook is launched in the core, it's in the doc and should be created by the core.
We don't use prestashop banner modules, we use our own banner module with is a modern widget module that don't have hardcoded hooks but can be hooked to any hook in positions bo menu.
This hook has to be in the database & hooks.xml, otherwise it will not be in the list of this bo page.

By the way, there is no other hook on top of the header block.

[PierreRambaud]

Ohh I understand (Sorry, little bit tired :sweat_smile: )
My bad, at least I learnt something new today !
I validate your pull request :)

[jf-viguier]

Thanks @PierreRambaud take care of you.