Prestashop: Creating an order with product with combination and shipped status leads to payment error

[matks]

Describe the bug
When creating an order from BO with product "Hummingbird printed sweater - size S", and choosing a status "shipped", the order is created BUT the order status is "payment error".

This is true on develop branch (1.7.7.0) but I dont reproduce the bug with 1.7.6.x branch so it seems to be a regression.

To Reproduce
Steps to reproduce the behavior:

1. Go into BO on "Create an order" legacy page (not symfony) (URL /admin-dev/index.php?controller=AdminOrders&id_order=8&vieworder)
2. Choose customer "John Doe"
3. Add product "Hummingbird printed sweater - size S" to cart
   

1. Choose order status "shipped"
2. Click "create order" button
3. You should be redirected to "view an order" page for the order you just created and see a "payment error" warning:
   

Some more notes:

• adding the product "The best is yet to come" in the cart is fine so the issue does not happen with any product
• other order statuses provide the same behavior, for example "payment accepted"

Additional information
PrestaShop version: develop
PHP version: 7.2

[matks]

Some more infos, as extra

• obviously we see the same issue while migrating the page to Symfony 😬it was 1st spotted by @Robin-Fischer-PS
• issue might come from PaymentModule class, lines 320 to 322 which set order status to payment error

[khouloudbelguith]

Hi @matks,

I did not manage to reproduce the issue with the develop branch (PS1.7.7.0.)
I attached a screen record
https://drive.google.com/file/d/1lKXwjYYOWX_YxN3zYBpb1xg-CZ7QDFYv/view
Thanks to check & feedback.

[matks]

😅 I dont know what to say ... it fails on my computer, and it does fail for @Robin-Fischer-PS too ...

[khouloudbelguith]

@matks, thanks!
I will try to re-install the shop & check.

Thanks!

[Robin-Fischer-PS]

Yes, I tried on develop branch too @khouloudbelguith

[khouloudbelguith]

@matks, @Robin-Fischer-PS, After fresh install develop => same issue
https://drive.google.com/file/d/1UIEaAgGFy4eepFjjgCfFEFEnn44nNCvv/view
I’ll add this to the debug roadmap.
Thanks!

[MatShir]

@PrestaShop/prestashop-qa @PrestaShop/prestashop-product-team Have you reproduce it?

[khouloudbelguith]

Hi @MatShir,

Yes, I manage to reproduce the issue with 1.7.7.x branch using
Orders page in legacy: https://drive.google.com/file/d/1QpT2RZtF-gXfddpkhXMRgtQqwsaUbxFi/view
Orders page migrated to Symfony: https://drive.google.com/file/d/1YOn_dqiTHne-fwdd_UJkaMNuMy0Wy1QY/view

Thanks!

[MatShir]

Thanks the problem seems to occur only for combination

[matthieu-rolland]

Fixed in this PR: #17404

[sam-pires]

Damn, too fast 🔥
Thanks @matthieu-rolland

We need to trim the bakclog with Mateus before you run out of issues