Prestashop: weird behavior when displayHeader is used in theme.yml

[jf-viguier]

Describe the bug
displayHeader usage in theme.yml causes a weird behavior : a new hook is created et launched before the header hook (the good one)

To Reproduce
Steps to reproduce the behavior:

1. add a displayHeader section in yout theme.yml with a module
2. Reinit the theme
3. Go to ps_hook and see displayHeader hook, the module should be hooked to the real header hook.
   In fact the module is hooked twice : in displayHeader and header hook.

displayHeader is an alias of header hook (ps_hook_alias). To follow 1.7 conventions this should be the other way around.

Additional information
PrestaShop version: 1.7.6.1
PHP version: 7.0

[khouloudbelguith]

Hi @jf-viguier,

Is it the same issue reported in this ticket: https://github.com/PrestaShop/PrestaShop/issues/10405?

Thanks!

[jf-viguier]

@khouloudbelguith no

[khouloudbelguith]

@jf-viguier, I did not manage to reproduce the issue with PS1.7.6.2 using this theme
childtheme-example.zip

Thanks to check & feedback.

[jf-viguier]

You can see the bug in your screenshot : the hook is displayHeader and should be just header

[khouloudbelguith]

@jf-viguier, thanks for these clarifications.
I manage to reproduce the issue with PS1.7.6.2 & PS1.7.5.2.

I’ll add this to the debug roadmap so that it’s fixed. If you have already fixed it on your end or if you think you can do it, please do send us a pull request!
Thanks!

[jf-viguier]

In fact, the official hook name should be displayHeader and header the alias, but I don't know the impact to rename a hook.
This should fix #10405