Prestashop: Jquery-migrate generates many messages in the console

[matthieu-rolland]

Since upgrading jquery and adding jquery-migrate, we have many warning logs in the console:

Screenshots

Questions needing answers

Should we remove them? Should it be kept here? Should we display it but only in dev environment ? If so, how is this done following best practices ?

[khouloudbelguith]

Ping @PrestaShop/prestashop-core-developers

[Progi1984]

@matthieu-rolland It seems that it's the normal behavior with the use of a development version : https://github.com/jquery/jquery-migrate#debugging. Else you can use jQuery.migrateMute.

[PierreRambaud]

We mustn't use jQuery.migrateMute. Like every deprecated messages we must do our best to update our code and always use latest functions.
This only mean we have some js codes that need to be updated :sweat_smile:

[matthieu-rolland]

@PierreRambaud that's the question, do we consider that those messages should be displayed even in production ?

[PierreRambaud]

I think yes, it's related to the front and only available in console, which means you're watching "js logs".
It will force everyone to update dependencies and fix it, instead of hiding them.
But maybe we need to have @eternoendless' feedbacks

[eternoendless]

Can this be enabled in dev mode and disabled in prod mode?
Do the deprecation messages only appear if the deprecated functions are used? In that case, we must update our usage of deprecated functions.

[PierreRambaud]

We should be able to use: https://github.com/jquery/jquery-migrate/blob/master/src/migratemute.js

[NeOMakinG]

Can this be enabled in dev mode and disabled in prod mode?
Do the deprecation messages only appear if the deprecated functions are used? In that case, we must update our usage of deprecated functions.

it looks like deprecated messages appears even if we don't use these functions, tried to find a "delegate" function use on FO core and classic files, couldn't find anything

BTW, we should maybe check every deprecated messages, in order to be sure we don't use any function that is deprecated!

[matthieu-rolland]

Can this be enabled in dev mode and disabled in prod mode?
Do the deprecation messages only appear if the deprecated functions are used? In that case, we must update our usage of deprecated functions.

it looks like deprecated messages appears even if we don't use these functions, tried to find a "delegate" function use on FO core and classic files, couldn't find anything

BTW, we should maybe check every deprecated messages, in order to be sure we don't use any function that is deprecated!

Definitely, maybe we can plan this for 1.7.8 ?

Because we will upgrade jquery to the next minor version. Dealing with these deprecations is probably not urgent for 1.7.7, and we're short on time for the 1.7.7 release...

[Progi1984]

Fixed by #20738