Prestashop: Our Payment modules are being considered as non-compatible in Prestashop 1.7+

[nexustotalsolutions]

Hello,

I'm a contributor on the Prestashop addons store with few modules. And there are 2 very popular payment modules on mine which are considered as not compatible from Prestashop 1.7+ version. There are 2 main issues:

1. These are listed under Other category instead of payment_gateways. And doesn't show on the Payment->Payment Methods. But module is showing under Payment->Preferences just fine.

1. Another issue is that the module gets auto deleted from the FTP while upgrading Prestashop with statement of non-compatibility.

Before I came to post this issue here, I got the answer from the Prestashop addons validating team that these bugs are due to the core.
My payment modules are:
https://addons.prestashop.com/en/product.php?id_product=17856
https://addons.prestashop.com/en/product.php?id_product=19407

Other then this, there is no issue present in the modules related with any PS 1.7+ non-compatibility.
There are lots clients who reported these issues but I can no more ignore this issue now.

Best Regards,
Dev

[khouloudbelguith]

Hi @nexustotalsolutions,

Thank you for your report.
We'll first try to reproduce it and we'll come back to you if we need more information.

Thanks!

[nexustotalsolutions]

Okay. Please let me know if you need me on anything else.

On Thu, 29 Aug 2019 at 9:46 PM, khouloudbelguith [e-mail]
wrote:

Hi @nexustotalsolutions https://github.com/nexustotalsolutions,

Thank you for your report.
We'll first try to reproduce it and we'll come back to you if we need more
information.

Thanks!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/PrestaShop/PrestaShop/issues/15298?email_source=notifications&email_token=ACLP2PLO3CLG3TEXPH2UOP3QG7Y5DA5CNFSM4IR6IA7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5PBAUQ#issuecomment-526258258,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACLP2PJMH6IUXLUVQHEGXMLQG7Y5DANCNFSM4IR6IA7A
.

>

Sent from my iPhone

[khouloudbelguith]

Hi @nexustotalsolutions,

Another issue is that the module gets auto deleted from the FTP while upgrading Prestashop with statement of non-compatibility.

Yes, after the upgrade, your module stripejs is deleted https://github.com/PrestaShop/autoupgrade/blob/973fa1ab91ee1b02736b08c1ad6cf3237b319e90/classes/TaskRunner/Upgrade/UpgradeModules.php#L94

Thanks!

[nexustotalsolutions]

Thanks for this diagnoses. Please suggest me on any further action to avoid it.
And also update me on the other issue of not displaying the module in Payment options.

Thank you.

[khouloudbelguith]

@nexustotalsolutions, it's the API that puts the modules in the right categories so it is not a PrestaShop Core issue.

Thanks!

[nexustotalsolutions]

Ohh I see!! So is there anything that can be done on my end to resolve this please?

[khouloudbelguith]

@nexustotalsolutions, I will try to speak to the addons market place team to check the API problem.

Thanks!

[nexustotalsolutions]

That'd be highly appreciated.

Thank you so much!!

[khouloudbelguith]

@nexustotalsolutions, you are welcome!

[nexustotalsolutions]

Any update on this issue please?

[khouloudbelguith]

@nexustotalsolutions, sorry, I didn't receive any response yet.
But, as I told you, it's the API that puts the modules in the right categories so it is not a PrestaShop Core issue.

[nexustotalsolutions]

Okay no problem!!

[Quetzacoalt91]

The API moves the different modules in the proper category only if the merchant is connected to its Marketplace account in the backoffice.
In the case he downloaded it from the marketplace (let's say from the URL given in the first link), then upload these modules manually in its Backoffice, the module will be stored in the "Others" category.

Actually we'd deal with a fallback here. If the marketplace has no information to provide to a module, we could use its tab property instead of the "Others" category by default.

[nexustotalsolutions]

Exactly @Quetzacoalt91

[colinegin]

There are 2 options :

1) we do as you recommend @Quetzacoalt91 : If the marketplace has no information to provide to a module, we could use its tab property instead of the "Others" category by default.

2) we make it more strict : we only rely on the category available in "tab", to remove any dependency with the Addons API. This implies that every module developer adds the correct category in the tab, otherwise they go to the Others category.

What do you think @Quetzacoalt91 @PierreRambaud ?

[Quetzacoalt91]

I'd go to the second option. It's seems only relying on the modules content is safer.

We can still use on the marketplace categories when looking for new modules (with MBO), but having them in the manager seems time-consuming for maintainers, and finally brings confusions for the merchants & module developers.

[PierreRambaud]

Agreed with @Quetzacoalt91 :)

[colinegin]

Alright, let's do it then !
Just an idea, don't you think we could use old categorization (1.6 categorization) that is still often available in "tab" and associate it to a new category ?
Let me give you an example : let's imagine a module where the contributor has never updated the tab as it is no longer used in 1.7. So the module's tab still displays "Analytics and Stats", which is today the equivalent of "Administration". We could do a correlation table, just to decide where the module could go in case it still displays old categories.
Wdyt @Quetzacoalt91 and @PierreRambaud ?

[PierreRambaud]

@colinegin No problem to add a correlation table :) We also could update our tab field values.

[colinegin]

Hello,

i've compared both lists, and here is the comparison table :

Old categorization | New categorization

Administration | Administration
Comparison site & Feed management | Trafic & Marketplaces
Slideshows | Design & Navigation
Quick / Bulk update | Administration
Export | Administration
Front office Features | Design & Navigation
Accounting & sales management | Administration
Content Management | Trafic & Marketplaces
International & Localization | Administration
Merchandising | Promotions & Marketing
Migration Tools | Administration
Payments and Gateways | Payment
Marketplace | Trafic & Marketplaces
Pricing and Promotion | Promotions & Marketing
Checkout | Administration
Checkout process | Administration
Advertising and Marketing | Promotions & Marketing
Search & Filters | Design & Navigation
SEO | Trafic & Marketplaces
Social Networks | Facebook & Social Networks
Shipping and Logistics | Shipping & Logistics
Analytics and Stats | Administration
Payment security | Payment
Mobile | Design & Navigation
Other modules | Other
Taxes & Invoicing | Administration
Dashboard | Administration
Emails & SMS | Promotions & Marketing

This means that if a module has one of the old categories in the tab value, this will classify it in the correct new category automatically. Of course, the module is also able to directly add in the tab field the correct new category where it needs to be found.