Prestashop: [EPIC] Add a modal to confirm or cancel delete in bulk actions

Created on 3 Jul 2019  路  14Comments  路  Source: PrestaShop/PrestaShop

Describe the bug
Add a modal like on product list (Catalog > Products) to confirm or cancel delete in bulk action and remove the other one

Already migrated pages for which it must be added:

  • [x] #17816 - Add a modal to confirm or cancel delete in bulk actions 1.7.7 [1/2]
  • [x] #17845 - Add a modal to confirm or cancel delete in bulk actions 1.7.8 [2/2]

Third part to do during the migration of each pages from 1.7.7
Pages not yet migrated for which it must be added:

  • [ ] Orders > Carts
  • [ ] Catalog > Attributes
  • [ ] Catalog > Features
  • [ ] Catalog > Discounts > Cart rules
  • [ ] Catalog > Discounts > Catalog price rules
  • [x] Customers > Addresses
  • [ ] Customers > Customer service
  • [x] Customers > Order messages - #18641
  • [ ] Design > Image settings
  • [ ] Shipping > Carriers
  • [ ] International > Locations > Zones
  • [ ] International > Locations > Countries
  • [ ] International > Locations > States
  • [ ] International > Taxes > Tax rules
  • [ ] International > Taxes > Tax rules > Edit a tax rule > Countries
  • [ ] Shop parameters > Customer settings > Titles
  • [ ] Shop parameters > Contact > Stores
  • [ ] Shop parameters > Traffic & SEO > Search engines
  • [ ] Shop parameters > Traffic & SEO > Referrers
  • [ ] Shop parameters > Search > Search
  • [ ] Shop parameters > Search > Tags

Screenshots

Add this modal (@LouiseBonnard for the wording, do you think it's better to have the same general wording for all or to have a specific one for each pages ?)

capture d'茅cran_1723

Remove this one

capture d'茅cran_1724

Epic Wording 鉁旓笍 migration

Most helpful comment

@colinegin WIP

As there are a huge number of pages to do, I do small PRs to modify them slowly and ease the work of QA. I check the items already done in this issue boyd.

All 14 comments

@matks FYI

@marionf, I think one global wording is better. Something like:

_Delete selection_
_Are you sure you want to (permanently) delete all selected items?_

Another thing is that it is currently possible to perform a bulk action with only one item selected. Do we want to keep this behavior? If yes, the wording should be adapted, like _Are you sure you want to delete the selected item(s)?_.

Yes, I think we can keep this behavior for now

@marionf, alright. In this case, let's write:

_Delete selection
Are you sure you want to delete the selected item(s)?_

1st implemention in PR https://github.com/PrestaShop/PrestaShop/pull/16820
When this one has been validated, I will enable it on all targeted pages.

@matks
I missed that there is also a confirmation when a single line is deleted
Do you think it's possible to implement also a modal for a single line at the same time or do you need another issue ?

@marionf you mean when you click on the row action? in the column at the right?

If yes, the good news is that with the component that @NeOMakinG created the modal should be reusable for this kind of behaviour as well.

@marionf you mean when you click on the row action? in the column at the right?

Yes

If yes, the good news is that with the component that @NeOMakinG created the modal should be reusable for this kind of behaviour as well.

Perfect :+1: I am going to create a new issue

Here it is: #17082

@marionf it seems "International > Localization > Currencies" page has no bulk delete action, probably because legacy page did not have bulk delete action too. Shall we introduce one ?

Well seen @matks
We will leave this page without checkboxes, I removed it from the list

@marionf @matks can you tell me what is the status of this issue ?

@colinegin WIP

As there are a huge number of pages to do, I do small PRs to modify them slowly and ease the work of QA. I check the items already done in this issue boyd.

Was this page helpful?
0 / 5 - 0 ratings