Prestashop: Ecotax and Cost price decimals are truncated on BO when the product has combinations

Created on 6 Jun 2019  路  6Comments  路  Source: PrestaShop/PrestaShop

Describe the bug
When we add an ecotax or a cost price with decimals to a product with combinations, it is truncated.

To Reproduce

  1. Go to the BO -> Products
  2. Edit a product with combinations
  3. Combinations tab -> Edit a combination
  4. Change the ecotax and the cost price for a price with decimals: 1.2345
  5. Save and leave the page
  6. Edit the same product, change the name, save and leave the page
  7. Edit the same product, see the combination edited before
  8. The decimals for the ecotax and cost price disappeared

* Screerecord *

https://drive.google.com/file/d/1B14gj0N4BFKpuZ6iI_eA_YgiYWUDs9gp/view?usp=sharing

* Additional information *
PrestaShop version: 1.7.5 -> 1.7.6, 1.7.7

Add $ ecotax = str_replace (',', '.', $ Ecotax); line 1859 and 1952.

1.7.5.2 1.7.6.0 1.7.7.0 BO Bug Combinations Major Must-have Products Taxes and Prices To Do

Most helpful comment

I reproduced the issue on 1.7.7.0, I edited the steps to reproduce and added a screenrecord

All 6 comments

Hi @itroom-agence,

I manage to reproduce the issue with PS:1.7.5.2 and PS 1.7.6.0beta1.
I鈥檒l add this to the debug roadmap so that it鈥檚 fixed. If you have already fixed it on your end or if you think you can do it, please do send us a pull request!
Thanks!

Hi @itroom-agence,
I manage to reproduce this issue :
https://drive.google.com/file/d/1A9z25EkRM5QkpW4pkXfp7eX9GzOmY5lA/view

Would you be willing to make a pull request on GitHub with your code suggestion?
https://github.com/PrestaShop/PrestaShop/tree/develop

Thank you

@sarahdib your video isn't available anymore

I tried to reproduce this issue on 1.7.7.x without success

@khouloudbelguith Could you try to reproduce it and link a video in the description if you reproduce it ?

Thanks

Hi @sarahdib @marionf,

I did not manage to reproduce the issue with PS1770rc1build2.
I attached a screen record
https://drive.google.com/file/d/1xUV7SFX5CucN1bCca7yIYunuu2y-AHoI/view?usp=sharing

Thanks!

I reproduced the issue on 1.7.7.0, I edited the steps to reproduce and added a screenrecord

Hi @itroom-agence

I had the same issue, your proposal seems to work.
PR: https://github.com/PrestaShop/PrestaShop/pull/22631

Thank you !

Was this page helpful?
0 / 5 - 0 ratings