Prestashop: Image Slider slide expiration date

[PrestaShark]

With this little feature we can prevent to show expired slider banners on homepage.

https://github.com/PrestaShop/ps_imageslider/pull/39

[khouloudbelguith]

Hi @PrestaShark,

Thanks for your suggestion & for your PR fix.
@marionf, @colinegin what do you think?
Thanks!

[colinegin]

Hello @PrestaShark, thanks for your idea and PR !
It's a nice improvement, I think we can review your code and test it.

We'll keep you posted.

Have a nice day !

[Quetzacoalt91]

Does the UX team want to have a look at this?

[TristanLDD]

Hi @PrestaShark, thank you for your contribution.

I suggest a few modifications on your interface:

• The expiration date would be better under the name of the slide, so it's position will not depend on the length of the name, so dates will be easier to 'scan'
• The color indication is not inclusive enough as some people might have troubles to differentiate colors. It's always better not to use color as the only information vector and add a clear wording.
• Please use the font open-sans for the date ;)

That would give us something like that:

[PrestaShark]

Hi guys and sorry for delay. I will work with all mentioned suggestions and brb soon! Have a good day and keep going with 1.7.6 :)

[hibatallahAouadni]

Hello @PrestaShark

Could you please apply the changes requested by @jolelievre on your PR.

Thanks!

[hibatallahAouadni]

Hello @PrestaShark ,

Since we had no news from you for more than 20 days, I'll close this ticket to avoid cluttering up the backlog.
Please note that you can always create a new one if further information pops up.

Thanks!