Prestashop: Order payment duplicated depending on order state configuration

[idnovate]

Describe the bug
If a state has these 3 options enabled, when you call validateOrder with this state the order payment is duplicated:

• Consider the associated order as validated.
• Set the order as paid.
• Show delivery PDF.

To Reproduce
Steps to reproduce the behavior:

1. Configure "Awaiting bank wire payment" order state with the 3 options enabled.
2. Create an order paid with bankwire
3. Check order payments

It doesn't happen when you change an order into an state with these 3 options, it only happens when it's called from ValdiateOrder.

Screenshots

Additionnal information
PrestaShop version: 1.7.5.0
PHP version: N/A

[khouloudbelguith]

Hi @idnovate,

Thanks for your report.
I manage to reproduce the issue with ps1.7.5.0 & PS1.7.4.4.

I’ll add this to the debug roadmap so that it’s fixed. If you have already fixed it on your end or if you think you can do it, please do send us a pull request!

A similar previous reported in the forge: http://forge.prestashop.com/browse/BOOM-4196
Thanks!

[ntiepresta]

Hi,

Same issue with Ps1.7.5.1 build1 and the develop branch.
Thanks!

[flexcodenet]

Hi,
Same issue with Ps 1.7.5.0.

Thanks.

[flexcodenet]

Any solution for this bug?

[khouloudbelguith]

Hi @flexcodenet,

Sorry, not yet.

[Prestaworks]

This issue is still present in 1.7.6.0 (it has been in Prestashop since 2015)

[khouloudbelguith]

@Prestaworks, sorry, it is not fixed yet.
There are some major issues to solve before this one.
So, it will probably not solved right now.
But PrestaShop is an open-source project, so it can be solved before if someone submits a pull request to solve it.

Thanks!

[Prestaworks]

Hi,

Maybe the software designer can help expain how it is supposed to work? today the payments are stored in orderpayments and invoicepayments and when a status is set with payed=1 it creates orderpayments if there are no invoicepayments. I do not want to try to fix this unless I know how it is supposed to work.

[khouloudbelguith]

Same issue with PS1.7.6.1

Thanks!

[Prestaworks]

I made a new pull request now for 1.7, basicly the same fix as was suggested 2018.
https://github.com/PrestaShop/PrestaShop/pull/15322

[khouloudbelguith]

Should be fixed by https://github.com/PrestaShop/PrestaShop/pull/18468
Ping @matks @erouvier29

Thanks!