Prestashop: Discount is not computed correctly with free gift

[idnovate]

Describe the bug
When 2 cart rules with a free gift are applied, discount is not computed correctly in cart summary

To Reproduce
Steps to reproduce the behavior:

1. Create 1 cart rule with a free gift
2. Create a 2nd rule with the same configuration than before
3. Check cart summary

Screenshots
Cart rule example

Cart problem

Additionnal information
PrestaShop version: Reproduced in PS 1.7.4.4 and PS 1.7.5 RC1

[khouloudbelguith]

Hi @idnovate,

Thanks for your report.
I manage to reproduce the issue with PS1.7.5.0rc1.
In the shopping cart page => NOK

In the order confirmation

In the order detail BO => NOK

The discount should be 68,92€

In the invoice => NOK

Thanks!

[marionf]

Related to #9757

[khouloudbelguith]

Hi,

This issue occurs also when we have two cart rules with free shipping vouchers as reported here #12024

Thanks!

[webstartconsulting]

Hi!
Its an important bug, any solution?

[khouloudbelguith]

Hi @webstartconsulting,

Sorry, not yet.

[idnovate]

Hi!

Same problem when 2 cart rules with free gift is applied.

• Create 2 cart rules like this:

• Shopping cart is €52.46 instead of €35.09:

[lijndiensten]

+1 on the urgency this issue. We are experiencing it on a live site and daily manual corrections, and emails to customers, are necessary because of it.

[venditdevs]

This is fixed by us in PR-13704 (Tomlev rebranched it ;))
https://github.com/PrestaShop/PrestaShop/pull/13704

(Tested on site of lijndiensten)

[marionf]

@venditdevs this issue is not fixed by #13704

If you have a fix, please make a pull request on GitHub with your code suggestion
https://github.com/PrestaShop/PrestaShop/tree/develop

Thank you!

[matks]

This is fixed by us in PR-13704 (Tomlev rebranched it ;))

13704

(Tested on site of lijndiensten)

Maybe in your case 🤔 but it seems there might be more cases where the bug still happens 😢 according to marionf

[venditdevs]

If i can find some time in the coming weeks i will take a look if i can fix this problem too
.
The cartrule code is mess. This wasn't tested before releasing 1.7.x , it just can 't be. So many errors and odd behaviours.

[jf-viguier]

We and some of our merchants in 1.7 are concerned by this issue.

[benlecoqartisans]

Hi,
Still no solution ? It's not a minor bug for us...
Any forecasted milestone ?

[ladisbot]

Hi,
any update for this bug?
Thank you :)

[khouloudbelguith]

Hi @ladisbot,

Sorry not yet.
PrestaShop is an open-source project, so it can be solved before if someone submits a pull request to solve it.

Thanks!

[Hlavtox]

@marionf @colinegin @khouloudbelguith @jf-viguier

Made a PR with a fix guys #16635. Test it please, should work fine.

[idnovate]

@marionf @colinegin @khouloudbelguith @jf-viguier

Made a PR with a fix guys #16635. Test it please, should work fine.

This PR fixes https://github.com/PrestaShop/PrestaShop/issues/11722#issuecomment-499413873. Tested with 1.7.6.2 which already includes https://github.com/PrestaShop/PrestaShop/pull/13704

[colinegin]

Thank you very much @Hlavtox !

[idnovate]

Unfortunately there is still some issue:

Issue 1:
Create the following rules:

• Rule 1
  Amount discount:
  

• Rule 2
  Free gift
  

• Rule 3
  Free gift
  

Cart:

Issue 2:

• Change the first rule:
  

• Discount is higher than amount
  

[Hlavtox]

@idnovate What if you set priority to gift rules to 1 and the discount rules to 2?

[idnovate]

Then all is OK:

[colinegin]

@Robin-Fischer-PS could you check @idnovate comments ?

Thanks !

[Hlavtox]

@colinegin

@idnovate is right, I didn't think of this situation. :-(

Order of cart rules must be - gifts first, discounts second, in order for the fix to work. Perhaps if you guys fixed this cart rule order as I proposed in #16642?

Because now, if you simulate @idnovate's situation:

• discount cartrule - it applies the discount for all products in cart, even the gift ones.
• gift cartrule - discounts the original product price, before the first cart rule was applied.

[khouloudbelguith]

Hi @idnovate, @colinegin, @Robin-Fischer-PS,

I manage to reproduce the issue described by @idnovate with the develop branch.
I will create a new issue.

Thanks!

[khouloudbelguith]

Hi @colinegin,

Issue created: https://github.com/PrestaShop/PrestaShop/issues/16673
I added the label Regression because, in the PS1.7.6.2 => the total is well calculated.
@colinegin what do you think?

Thanks!

[colinegin]

Yes @khouloudbelguith , I agree with you. I add it to the 1.7.7 kanban.