Prefect: K8s Agent references old prefect docker image name

Created on 4 Nov 2019  路  4Comments  路  Source: PrefectHQ/prefect

Description

Whenever the kubernetes agent creates a job, it references our old docker image naming conventions in at least on place here. We should audit all such references and update them for our new naming scheme, which can be inferred from our circleci/config.yml file here

cc: @joshmeek

bug

All 4 comments

Due to the tagging changes we have a couple options around "prefecthq/prefect:{}".format(image_version)

  1. Add a check here to use the new tagging conventions for >= 0.7.0 and old simple version convention for < 0.7.0
  2. Add a new tag to the old images to follow the new convention in order to avoid a check

option 2.) seems like the easiest to me - no maintenance burden, just a one time tag / push of a lot of images

@cicdw Okay great, I'll make the PR and before it's merged we can tag those old images

Images for 0.6.7 and 0.6.6 have been built and pushed with the new naming schema.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

WilliamBurdett picture WilliamBurdett  路  3Comments

dkapitan picture dkapitan  路  3Comments

kforti picture kforti  路  3Comments

joshmeek picture joshmeek  路  4Comments

jameslamb picture jameslamb  路  3Comments