Preact: why preact props has default children?

[vn-liu]

i didn't has children props,

but i console this datepicker proptypes, why has a children is undefined?

[developit]

Preact normalizes children in h() - it will always set props.children to an Array. preact-compat undoes this for React-style components, which is why you're seeing the undefined. Deleting the property would mutate the shape of props and hurt performance, so it is simply set to undefined.

[webdeb]

@developit hmm, could we disable default children array? with an attribute like noChilds ?

[webdeb]

Just faced that issue with paypal integration, they are validating the props, and they only allow some limited props.. (children is not included)

Really, don't want to install preact-compat just for this.

[sxcooler]

@developit I'm a colleague of @a993630 , I understand your pursuit of performance, but this hurt the compatibility of Preact. Unlike @webdeb , my project has included preact-compat, but still got some warnings with prop-types.
Not all the third-party packages is well-maintained / quickly-responded, nor every project would like to change some code to fit Preact, this means hurting the eco-system of Preact.
Please consider.

[webdeb]

@developit this will prevent adding undefined children to props https://github.com/developit/preact/pull/774

[developit]

I'm happy with the proposed solution in #774. The issue I had was that, when not using preact-compat, props.children is always an Array in Preact. This is done intentionally, to avoid requiring the entire React.Children API, which exists only because children is an unknown object in React.

[Zeroster]

We are also experiencing an issue with a 3rd party React library that is not compatible with undefined children when using preact-compat.

@webdeb Any progress on #774 or #822?

[webdeb]

Hey @Zeroster, because #822 adds more complexity, I decided to re-open #774 again. If @developit is still OK with it, it would make me proud if #774 could be merged any time soon. Btw, this would also allow me to use the official Preact package instead of mine custom fork in one of my projects ;)

[theramparts]

This is something that my team needs. Are there any updates on the progress of this issue? Information is appreciated. Thanks!

[webdeb]

@theramparts #774 should be ok to merge, IMHO

[theramparts]

@developit Can we get this merged in? My team would be very appreciative! Thanks.

[marvinhagemeister]

We just merged #1302 which doesn't automatically add props.children anymore :+1: