Preact-cli: Link to my default TypeScript template, or add it to the templates org

Created on 16 May 2018  路  10Comments  路  Source: preactjs/preact-cli


Do you want to request a feature or report a bug?

Feature

I have created a TypeScript template, based on the default template. It might be good to add it to @preactjs-templates, or at least link it from the readme. You can find it here: preact-default-typescript. If there's interest I could port some of the other templates too.

Most helpful comment

Thanks @ForsakenHarmony. I've made a few updates and pushed, and successfully tried preact create typescript my-project. The repo was based on the default boilerplate back in May, but I've updated the dependencies and applied a couple of other updates from the original repo. I'm happy to close this now.

All 10 comments

Maybe remove all the "Aerian studios" stuff if this is supposed to be a "default" template, i.e. this defaults to the style guide used by aerian which can lead to obscure issues because people don't realise that.

@SleeplessByte Which style guide would you suggest we use? As far as I was aware, Preact doesn't have a TypeScript styleguide of its own (or at least it didn't when I wrote it). There shouldn't be anything particularly controversial in there.

I've removed the dependency and moved the rules into the project.

@SleeplessByte Which style guide would you suggest we use? As far as I was aware, Preact doesn't have a TypeScript styleguide of its own (or at least it didn't when I wrote it). There shouldn't be anything particularly controversial in there.

Your styles are highly opinionated, which is a good thing, but hiding it in a dependency, for a template, in my opinion is not, because preact does not have a default styleguide! By moving them into the template, people can easily change the rules, so that to me is the way to go <3

I think it's pretty awesome - I just delete the linting parts as I do with the default template. (which shows errors when using prettier)

@SleeplessByte Which style guide would you suggest we use? As far as I was aware, Preact doesn't have a TypeScript styleguide of its own (or at least it didn't when I wrote it). There shouldn't be anything particularly controversial in there.

Your styles are highly opinionated, which is a _good_ thing, but hiding it in a dependency, for a template, in my opinion is not, because preact does not have a default styleguide! By moving them into the template, people can easily change the rules, so that to me is the way to go <3

Isn't the default template doing this as well:
image

Didn't prettier win? ;)

@bestwestern The style guide I use for this is prettier, but with extra non-formatting rules.

@ascorbic That part was about the default template, where if I use the prettier plugin in VS Code and then 'npm run lint' I get plenty of errors:
image

Your template is too strict for my taste - a method in a component requires public/private in front of it.

I think there's a problem with the async routes:
https://github.com/developit/preact-cli/issues/560#issue-317529996

Feel free to push to the template repo I just invited you to, we can figure the rest out there

Thanks @ForsakenHarmony. I've made a few updates and pushed, and successfully tried preact create typescript my-project. The repo was based on the default boilerplate back in May, but I've updated the dependencies and applied a couple of other updates from the original repo. I'm happy to close this now.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

higimo picture higimo  路  3Comments

hardcoar picture hardcoar  路  3Comments

ajay28kumar picture ajay28kumar  路  3Comments

oren picture oren  路  4Comments

scottmas picture scottmas  路  3Comments