Preact-cli: Recipe for disabling sourcemaps doesn't work

[GusRuss89]

Do you want to request a feature or report a bug?
Bug

What is the current behaviour?
Recipe for disabling sourcemaps doesn't work. Code seems to run twice, and the second time it runs, the result of helpers.getPluginsByName(config, "UglifyJsPlugin")[0] is undefined.

The full recipe code.

export default (config, env, helpers) => {
  let { plugin } = helpers.getPluginsByName(config, "UglifyJsPlugin")[0];
  plugin.options.sourceMap = false
}

My exact config. Note this is a custom config file - preact.config.prod.js

const webpack = require('webpack')

module.exports = function(config, env, helpers) {
  config.plugins.push(
    new webpack.DefinePlugin({
      SLS_ENDPOINT_BASE: JSON.stringify('unrelated')
    })
  )

  /* This runs twice, and the second time, uglify is undefined */
  const uglify = helpers.getPluginsByName(config, 'UglifyJsPlugin')[0]
  console.log(JSON.stringify(uglify))
  console.log(typeof uglify)
  uglify.plugin.options.sourceMap = false
}

I get the same result if I comment out the config.plugins.push part, and also if I change to export default.

If the current behaviour is a bug, please provide the steps to reproduce.

• Create custom config file
• Enter my code (above)
• Run preact build --config my.preact.config.js
• Note console output above the error

What is the expected behaviour?
No errors, turn off source maps in build.

If this is a feature request, what is motivation or use case for changing the behaviour?

Please mention other relevant information.

• Node version: 9.8.0
• npm version: 5.6.0
• Operating system: Mac OS High Sierra
• CLI version: 2.2.1
• Browser: n/a

[lukeed]

You have to disable it via webpack config actually. I'll follow up with a snippet after dinner

[lukeed]

So, at least in my case, I want to disable sourcemaps for production:

// preact.config.js

module.exports = function (config, env) {
  if (env.isProd) {
    config.devtool = false; // disable sourcemaps
  }
}

You can go thru the trouble of disabling sourcemaps individually for each plugin -- I have tried, it doesn't work. This is because webpack still is the ultimate decider in whether or not maps should be emitted.

That said, this disables _all_ mappings.

[GusRuss89]

Thanks, this works for my use case :) Should I close the issue or do you want to leave it open until the recipe is updated?

[lukeed]

Great! Let's go ahead & close it 😄There are a lot of changes in the works, and we'll touch on the recipes area too

Thanks!